Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 277913002: Presubmit checks recover. (Closed)

Created:
6 years, 7 months ago by Igor Sheludko
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Presubmit checks recover: 1) runtime/references checks temporarily disabled (56 items left) 2) other errors fixed R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21222

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -216 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M include/v8-profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M include/v8-util.h View 1 chunk +1 line, -1 line 0 comments Download
M src/allocation-site-scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/constants-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/simulator-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm64/constants-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/cpu-arm64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/cpu-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-arm64.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/elements.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/constants-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/constants-mips.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M src/mips/disasm-mips.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 15 chunks +19 lines, -19 lines 0 comments Download
M src/objects.h View 1 chunk +7 lines, -7 lines 0 comments Download
M src/preparse-data.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler-tracer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +137 lines, -137 lines 0 comments Download
M test/cctest/test-semaphore.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/presubmit.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 7 months ago (2014-05-09 12:48:18 UTC) #1
Jakob Kummerow
lgtm
6 years, 7 months ago (2014-05-09 12:53:19 UTC) #2
Igor Sheludko
6 years, 7 months ago (2014-05-09 12:59:57 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r21222 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698