Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2779053002: Ignore OWNERS files during external/wpt import and export (Closed)

Created:
3 years, 8 months ago by Sergiy Byelozyorov
Modified:
3 years, 8 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore OWNERS files during external/wpt import and export R=qyearsley@chromium.org BUG=702283 Review-Url: https://codereview.chromium.org/2779053002 Cr-Commit-Position: refs/heads/master@{#460190} Committed: https://chromium.googlesource.com/chromium/src/+/54b5563663f325d159f01efa846e74c803c65119

Patch Set 1 #

Patch Set 2 : Fix #

Total comments: 2

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 2 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Sergiy Byelozyorov
3 years, 8 months ago (2017-03-28 13:59:13 UTC) #1
qyearsley
LGTM with a couple minor suggestions. The test looks good and extracting out _clear_out_dest_path was ...
3 years, 8 months ago (2017-03-28 14:49:30 UTC) #6
Sergiy Byelozyorov
https://codereview.chromium.org/2779053002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py (right): https://codereview.chromium.org/2779053002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py#newcode96 third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py:96: os.path.basename(f) == 'OWNERS') On 2017/03/28 14:49:29, qyearsley wrote: > ...
3 years, 8 months ago (2017-03-28 17:36:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779053002/40001
3 years, 8 months ago (2017-03-28 17:36:25 UTC) #14
qyearsley
On 2017/03/28 at 17:36:13, sergiyb wrote: > https://codereview.chromium.org/2779053002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py > File third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py (right): > > https://codereview.chromium.org/2779053002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py#newcode96 ...
3 years, 8 months ago (2017-03-28 18:40:18 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 19:39:39 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/54b5563663f325d159f01efa846e...

Powered by Google App Engine
This is Rietveld 408576698