Ignore OWNERS files during external/wpt import and export

third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import os.path
+
 from webkitpy.w3c.chromium_finder import absolute_chromium_dir, absolute_chromium_wpt_dir
 
 CHROMIUM_WPT_DIR = 'third_party/WebKit/LayoutTests/external/wpt/'
 
 
 class ChromiumCommit(object):
 
     def __init__(self, host, sha=None, position=None):
         """
         Args:
@@ skipping 65 matching lines @@
             'git', 'diff-tree', '--name-only', '--no-commit-id', '-r', self.sha,
             '--', self.absolute_chromium_wpt_dir
         ], cwd=self.absolute_chromium_dir).splitlines()
 
         blacklist = [
             'MANIFEST.json',
             self.host.filesystem.join('resources', 'testharnessreport.js'),
         ]
         qualified_blacklist = [CHROMIUM_WPT_DIR + f for f in blacklist]
 
-        return [f for f in changed_files if f not in qualified_blacklist and not self.is_baseline(f)]
+        is_ignored = lambda f: (
+            f in qualified_blacklist or
+            self.is_baseline(f) or
+            # See http://crbug.com/702283 for context.
+            os.path.basename(f) == 'OWNERS')

[qyearsley, 2017/03/28 14:49:29]

If you use self.host.filesystem.basename() here, then we don't need to import
os.path.

Also, at this point this lambda is getting big enough that we could optionally
extract out a private method or a nested function.

[Sergiy Byelozyorov, 2017/03/28 17:36:13]

Done.
IMHO it only makes sense to make it private function if other methods are going
to make use of it. Perhaps it can be defined as an inline function at some
point, but I think it's short enough to keep it as lambda for now.

+        return [f for f in changed_files if not is_ignored(f)]
 
     @staticmethod
     def is_baseline(basename):
         # TODO(qyearsley): Find a better, centralized place for this.
         return basename.endswith('-expected.txt')
 
     def format_patch(self):
         """Makes a patch with only exportable changes."""
         filtered_files = self.filtered_changed_files()
 
         if not filtered_files:
             return ''
 
         return self.host.executive.run_command([
             'git', 'format-patch', '-1', '--stdout', self.sha, '--'
         ] + filtered_files, cwd=self.absolute_chromium_dir)