Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py

Issue 2779053002: Ignore OWNERS files during external/wpt import and export (Closed)
Patch Set: Addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
index ab3a5d3ef4ecdb30e20bc98458384b3381422ea7..af9e466478a355197e5f6acfccf45e3a9f438da0 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
@@ -87,7 +87,12 @@ class ChromiumCommit(object):
]
qualified_blacklist = [CHROMIUM_WPT_DIR + f for f in blacklist]
- return [f for f in changed_files if f not in qualified_blacklist and not self.is_baseline(f)]
+ is_ignored = lambda f: (
+ f in qualified_blacklist or
+ self.is_baseline(f) or
+ # See http://crbug.com/702283 for context.
+ self.host.filesystem.basename(f) == 'OWNERS')
+ return [f for f in changed_files if not is_ignored(f)]
@staticmethod
def is_baseline(basename):
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698