Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2778443002: Move AsyncTask helpers for accounts and features getters to AccountManagerHelper (Closed)

Created:
3 years, 9 months ago by bsazonov
Modified:
3 years, 9 months ago
Reviewers:
msarda
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move AsyncTask helpers for accounts and features getters to AccountManagerHelper This CL moves AsyncTask management from AccountManagerHelper delegates to AccountManagerHelper itself (see bug for details). BUG=698258 Review-Url: https://codereview.chromium.org/2778443002 Cr-Commit-Position: refs/heads/master@{#459736} Committed: https://chromium.googlesource.com/chromium/src/+/4a6245e626500c412e86e74e110542d33408e679

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Messages

Total messages: 14 (9 generated)
bsazonov
Mihai, please take a look.
3 years, 9 months ago (2017-03-24 16:17:39 UTC) #6
msarda
LGTM with a nit. https://codereview.chromium.org/2778443002/diff/1/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java File components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java (right): https://codereview.chromium.org/2778443002/diff/1/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java#newcode360 components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java:360: String[] features = {FEATURE_IS_CHILD_ACCOUNT_KEY}; Nit: ...
3 years, 9 months ago (2017-03-27 09:09:10 UTC) #7
bsazonov
https://codereview.chromium.org/2778443002/diff/1/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java File components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java (right): https://codereview.chromium.org/2778443002/diff/1/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java#newcode360 components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java:360: String[] features = {FEATURE_IS_CHILD_ACCOUNT_KEY}; On 2017/03/27 09:09:09, msarda wrote: ...
3 years, 9 months ago (2017-03-27 09:27:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778443002/20001
3 years, 9 months ago (2017-03-27 09:28:24 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 10:05:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4a6245e626500c412e86e74e1105...

Powered by Google App Engine
This is Rietveld 408576698