Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java

Issue 2778443002: Move AsyncTask helpers for accounts and features getters to AccountManagerHelper (Closed)
Patch Set: Addressed comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java
diff --git a/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java b/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java
index acfe62cbbf66ee3234cd7bc02f9ebbd8b9fc466a..abe76c0ca6c313c01190ff52be3c0bea63772825 100644
--- a/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java
+++ b/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java
@@ -180,8 +180,18 @@ public class AccountManagerHelper {
/**
* Retrieves all Google accounts on the device asynchronously.
*/
- public void getGoogleAccounts(Callback<Account[]> callback) {
- mAccountManager.getAccountsByType(GOOGLE_ACCOUNT_TYPE, callback);
+ public void getGoogleAccounts(final Callback<Account[]> callback) {
+ new AsyncTask<Void, Void, Account[]>() {
+ @Override
+ protected Account[] doInBackground(Void... params) {
+ return getGoogleAccounts();
+ }
+
+ @Override
+ protected void onPostExecute(Account[] accounts) {
+ callback.onResult(accounts);
+ }
+ }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
}
/**
@@ -347,8 +357,26 @@ public class AccountManagerHelper {
}
public void checkChildAccount(Account account, Callback<Boolean> callback) {
- String[] features = {FEATURE_IS_CHILD_ACCOUNT_KEY};
- mAccountManager.hasFeatures(account, features, callback);
+ hasFeatures(account, new String[] {FEATURE_IS_CHILD_ACCOUNT_KEY}, callback);
+ }
+
+ private boolean hasFeatures(Account account, String[] features) {
+ return mAccountManager.hasFeatures(account, features);
+ }
+
+ private void hasFeatures(
+ final Account account, final String[] features, final Callback<Boolean> callback) {
+ new AsyncTask<Void, Void, Boolean>() {
+ @Override
+ public Boolean doInBackground(Void... params) {
+ return hasFeatures(account, features);
+ }
+
+ @Override
+ public void onPostExecute(Boolean value) {
+ callback.onResult(value);
+ }
+ }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
}
/**

Powered by Google App Engine
This is Rietveld 408576698