Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java

Issue 2778443002: Move AsyncTask helpers for accounts and features getters to AccountManagerHelper (Closed)
Patch Set: Addressed comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
diff --git a/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java b/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
index 6cc91e8c3a598fb0061c99b921481f71e47c17a0..59767799a3df0857fbaf350095ffd28ad948ce76 100644
--- a/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
+++ b/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
@@ -15,7 +15,6 @@ import android.accounts.OperationCanceledException;
import android.app.Activity;
import android.content.Context;
import android.content.pm.PackageManager;
-import android.os.AsyncTask;
import android.os.Build;
import android.os.Bundle;
import android.os.Process;
@@ -64,21 +63,6 @@ public class SystemAccountManagerDelegate implements AccountManagerDelegate {
}
@Override
- public void getAccountsByType(final String type, final Callback<Account[]> callback) {
- new AsyncTask<Void, Void, Account[]>() {
- @Override
- protected Account[] doInBackground(Void... params) {
- return getAccountsByType(type);
- }
-
- @Override
- protected void onPostExecute(Account[] accounts) {
- callback.onResult(accounts);
- }
- }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
- }
-
- @Override
public String getAuthToken(Account account, String authTokenScope) throws AuthException {
assert !ThreadUtils.runningOnUiThread();
assert AccountManagerHelper.GOOGLE_ACCOUNT_TYPE.equals(account.type);
@@ -128,23 +112,6 @@ public class SystemAccountManagerDelegate implements AccountManagerDelegate {
return false;
}
- @Override
- public void hasFeatures(
- final Account account, final String[] features, final Callback<Boolean> callback) {
- AsyncTask<Void, Void, Boolean> task = new AsyncTask<Void, Void, Boolean>() {
- @Override
- public Boolean doInBackground(Void... params) {
- return hasFeatures(account, features);
- }
-
- @Override
- public void onPostExecute(Boolean value) {
- callback.onResult(value);
- }
- };
- task.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
- }
-
/**
* Records a histogram value for how long time an action has taken using
* {@link RecordHistogram#recordTimesHistogram(String, long, TimeUnit))} iff the browser

Powered by Google App Engine
This is Rietveld 408576698