Issue 2778113003: Fix popunders spawned from a subframe.

Issue 2778113003: Fix popunders spawned from a subframe. (Closed)

Created:
3 years, 8 months ago by Avi (use Gerrit)

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Fix popunders spawned from a subframe. BUG=705316 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2773403002 Cr-Commit-Position: refs/heads/master@{#459835} (cherry picked from commit 8d1aa16d8f9e854e3f099f9fad9866efe072f821) Review-Url: https://codereview.chromium.org/2778113003 . Cr-Commit-Position: refs/branch-heads/3029@{#458} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7b3733eb24574660bc2b4aeb4b3e5147cae06a88

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -3 lines)			Patch
M	chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A +	chrome/test/data/popup_blocker/popup-subframe.html	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	chrome/test/data/popup_blocker/popup-window-subframe-open.html	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	content/browser/frame_host/frame_tree_node.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/frame_host/frame_tree_node.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Avi (use Gerrit)

3 years, 8 months ago (2017-03-28 20:02:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7b3733eb24574660bc2b4aeb4b3e5147cae06a88.