chrome/test/data/popup_blocker/popup-subframe.html - Issue 2778113003: Fix popunders spawned from a subframe.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/popup_blocker/popup-subframe.html

Issue 2778113003: Fix popunders spawned from a subframe. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <title>Popup created using window.open</title>	3 <title>Popup created using window.open</title>

4 <script>	4 <script>

5 function test() {	5 function test() {

6 window.open("data:text/html,<title>Popup Success!</title>" +	6 window.open("data:text/html,<title>Popup Success!</title>" +

7 "you should not see this message if popup blocker is enabled",	7 "you should not see this message if popup blocker is enabled",

8 "mywindow", "menubar=1, resizable=1, width=350, height=250");	8 "mywindow", "menubar=1, resizable=1, width=350, height=250");

	9 window.parent.deleteframe();

9 }	10 }

10 </script>	11 </script>

11 </head>	12 </head>

12 <body onload="test()">	13 <body onload="test()">

13 pop-up test page	14 pop-up test page

14 </body>	15 </body>

15 </html>	16 </html>

OLD	NEW