Fix popunders spawned from a subframe.

Fix popunders spawned from a subframe.

BUG=705316
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2773403002
Cr-Commit-Position: refs/heads/master@{#459835}
Committed: https://chromium.googlesource.com/chromium/src/+/8d1aa16d8f9e854e3f099f9fad9866efe072f821

[Avi (use Gerrit), 2017-03-27 01:32:23]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 01:32:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-03-27 02:16:22]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 02:16:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 03:06:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 03:06:04]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-03-27 03:06:13]

avi@chromium.org changed reviewers:
+ alexmos@chromium.org, jochen@chromium.org

[Avi (use Gerrit), 2017-03-27 03:06:13]

Jochen: popunder stuff
Alex: frame double-checking

[jochen (gone - plz use gerrit), 2017-03-27 05:15:40]

Good catch!

Maybe update the comment on the getter for the original opener to reflect that
it's the main frame?

LGTM overall

[Avi (use Gerrit), 2017-03-27 14:59:00]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2017-03-27 14:59:02]

Description was changed from

==========
Fix popunders spawned from a subframe.

BUG=705316
==========

to

==========
Fix popunders spawned from a subframe.

BUG=705316
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-03-27 14:59:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 15:50:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 15:50:22]

Dry run: This issue passed the CQ dry run.

[alexmos, 2017-03-27 16:51:32]

LGTM, nice catch.  Yeah, it might make more sense to track the original opener
as WebContents, but this is easier and probably better for now, given that
you'll be merging this.

Perhaps also add a check in FTN::SetOriginalOpener that whatever's passed in is
either null or a root FTN?

https://codereview.chromium.org/2773403002/diff/40001/chrome/browser/ui/block...
File chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc (right):

https://codereview.chromium.org/2773403002/diff/40001/chrome/browser/ui/block...
chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc:602: // Verify
that popunders from subframes are prevented.
Maybe reference 705316 here?

[Avi (use Gerrit), 2017-03-27 17:08:15]

Thank you!

https://codereview.chromium.org/2773403002/diff/40001/chrome/browser/ui/block...
File chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc (right):

https://codereview.chromium.org/2773403002/diff/40001/chrome/browser/ui/block...
chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc:602: // Verify
that popunders from subframes are prevented.
On 2017/03/27 16:51:32, alexmos wrote:
> Maybe reference 705316 here?

Done.

[Avi (use Gerrit), 2017-03-27 17:09:25]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2017-03-27 17:09:26]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
alexmos@chromium.org
Link to the patchset: https://codereview.chromium.org/2773403002/#ps60001
(title: "alex")

[commit-bot: I haz the power, 2017-03-27 17:09:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 18:27:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490634565759220,
"parent_rev": "7bc9bd3a6fa05f39eab314b3193e2ba382e96b45", "commit_rev":
"8d1aa16d8f9e854e3f099f9fad9866efe072f821"}

[commit-bot: I haz the power, 2017-03-27 18:28:28]

Description was changed from

==========
Fix popunders spawned from a subframe.

BUG=705316
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix popunders spawned from a subframe.

BUG=705316
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2773403002
Cr-Commit-Position: refs/heads/master@{#459835}
Committed:
https://chromium.googlesource.com/chromium/src/+/8d1aa16d8f9e854e3f099f9fad98...
==========

[commit-bot: I haz the power, 2017-03-27 18:28:29]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8d1aa16d8f9e854e3f099f9fad98...