Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2778053003: Revert of Enable -Wdeprecated-register. (Closed)

Created:
3 years, 9 months ago by satorux1
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable -Wdeprecated-register. (patchset #5 id:80001 of https://codereview.chromium.org/2780623003/ ) Reason for revert: Broke os="chromeos" build: crbug.com/705812 Original issue's description: > Enable -Wdeprecated-register. > > No behavior change. > > BUG=255186 > > Review-Url: https://codereview.chromium.org/2780623003 > Cr-Commit-Position: refs/heads/master@{#459973} > Committed: https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb6cec33fae6f2 TBR=dcheng@chromium.org,rouslan@chromium.org,kbr@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=255186 Review-Url: https://codereview.chromium.org/2778053003 Cr-Commit-Position: refs/heads/master@{#459989} Committed: https://chromium.googlesource.com/chromium/src/+/f9a94c24489a558b43f6938e86d6c4e69cc52afb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -125 lines) Patch
M base/third_party/dmg_fp/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
M base/third_party/dmg_fp/g_fmt.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_css_property_names.py View 2 chunks +48 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_css_value_keywords.py View 2 chunks +17 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/ColorData.gperf View 2 chunks +3 lines, -14 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 6 chunks +7 lines, -21 lines 0 comments Download
M third_party/mesa/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
satorux1
Created Revert of Enable -Wdeprecated-register.
3 years, 9 months ago (2017-03-28 02:28:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778053003/1
3 years, 9 months ago (2017-03-28 02:28:54 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 02:30:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9a94c24489a558b43f6938e86d6...

Powered by Google App Engine
This is Rietveld 408576698