Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2778053003: Revert of Enable -Wdeprecated-register. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/compiler.gni") 8 import("//build/config/compiler/compiler.gni")
9 import("//build/config/nacl/config.gni") 9 import("//build/config/nacl/config.gni")
10 import("//build/toolchain/cc_wrapper.gni") 10 import("//build/toolchain/cc_wrapper.gni")
(...skipping 1046 matching lines...) Expand 10 before | Expand all | Expand 10 after
1057 # This warns on using ints as initializers for floats in 1057 # This warns on using ints as initializers for floats in
1058 # initializer lists (e.g. |int a = f(); CGSize s = { a, a };|), 1058 # initializer lists (e.g. |int a = f(); CGSize s = { a, a };|),
1059 # which happens in several places in chrome code. Not sure if 1059 # which happens in several places in chrome code. Not sure if
1060 # this is worth fixing. 1060 # this is worth fixing.
1061 "-Wno-c++11-narrowing", 1061 "-Wno-c++11-narrowing",
1062 1062
1063 # Warns on switches on enums that cover all enum values but 1063 # Warns on switches on enums that cover all enum values but
1064 # also contain a default: branch. Chrome is full of that. 1064 # also contain a default: branch. Chrome is full of that.
1065 "-Wno-covered-switch-default", 1065 "-Wno-covered-switch-default",
1066 1066
1067 # Clang considers the `register` keyword as deprecated, but e.g.
1068 # code generated by flex (used in angle) contains that keyword.
1069 # http://crbug.com/255186
1070 "-Wno-deprecated-register",
1071
1067 # TODO(thakis): This used to be implied by -Wno-unused-function, 1072 # TODO(thakis): This used to be implied by -Wno-unused-function,
1068 # which we no longer use. Check if it makes sense to remove 1073 # which we no longer use. Check if it makes sense to remove
1069 # this as well. http://crbug.com/316352 1074 # this as well. http://crbug.com/316352
1070 "-Wno-unneeded-internal-declaration", 1075 "-Wno-unneeded-internal-declaration",
1071 1076
1072 # TODO(hans): Get this cleaned up, http://crbug.com/428099 1077 # TODO(hans): Get this cleaned up, http://crbug.com/428099
1073 "-Wno-inconsistent-missing-override", 1078 "-Wno-inconsistent-missing-override",
1074 ] 1079 ]
1075 1080
1076 # Chrome's hermetic Clang compiler, NaCl's Clang compiler and Xcode's Clang 1081 # Chrome's hermetic Clang compiler, NaCl's Clang compiler and Xcode's Clang
(...skipping 633 matching lines...) Expand 10 before | Expand all | Expand 10 after
1710 1715
1711 if (is_ios || is_mac) { 1716 if (is_ios || is_mac) {
1712 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1717 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1713 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1718 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1714 config("enable_arc") { 1719 config("enable_arc") {
1715 common_flags = [ "-fobjc-arc" ] 1720 common_flags = [ "-fobjc-arc" ]
1716 cflags_objc = common_flags 1721 cflags_objc = common_flags
1717 cflags_objcc = common_flags 1722 cflags_objcc = common_flags
1718 } 1723 }
1719 } 1724 }
OLDNEW
« no previous file with comments | « base/third_party/dmg_fp/g_fmt.cc ('k') | third_party/WebKit/Source/build/scripts/make_css_property_names.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698