Enable -Wdeprecated-register (except on CrOS and 32-bit Linux).

Enable -Wdeprecated-register (except on CrOS and 32-bit Linux).

No behavior change.

BUG=255186, 705812
Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Original-Commit-Position: refs/heads/master@{#459973}
Committed: https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb6cec33fae6f2
Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Commit-Position: refs/heads/master@{#460879}
Committed: https://chromium.googlesource.com/chromium/src/+/a46872ca96d862816f993c16d6c270af26290247
Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#461102}
Committed: https://chromium.googlesource.com/chromium/src/+/755d274e7b3e893719322489b07a5d929328caa0

[Nico, 2017-03-27 19:40:47]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 19:41:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 21:41:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 21:41:02]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-03-27 22:24:34]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2017-03-27 22:25:04]

Description was changed from

==========
try -Wdeprecated-register

.

BUG=
==========

to

==========
try -Wdeprecated-register

.

BUG=255186
==========

[commit-bot: I haz the power, 2017-03-27 22:25:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-27 22:25:23]

Description was changed from

==========
try -Wdeprecated-register

.

BUG=255186
==========

to

==========
Enable -Wdeprecated-register.

No behavior change.

BUG=255186
==========

[Nico, 2017-03-27 22:26:21]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 22:26:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-27 22:27:14]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:42:32]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Nico, 2017-03-27 22:56:02]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 22:56:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-03-27 23:01:23]

lgtm

[commit-bot: I haz the power, 2017-03-27 23:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 23:10:17]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Nico, 2017-03-27 23:11:20]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 23:12:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-27 23:42:04]

thakis@chromium.org changed reviewers:
+ kbr@chromium.org, rouslan@chromium.org

[Nico, 2017-03-27 23:42:04]

rouslan: addressinput
kbr: mesa

It'd be good if you could work with your respective upstreams to get this fixed,
word on the street is this will become a hard error in c++17.

[Ken Russell (switch to Gerrit), 2017-03-28 00:18:14]

lgtm

sugoi@ and capn@ are working on incorporating SwiftShader, which will completely
replace Mesa. This third-party dependency won't be required much longer.

[commit-bot: I haz the power, 2017-03-28 00:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 00:59:24]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-03-28 01:29:11]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-28 01:29:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2780623003/#ps80001
(title: ".")

[commit-bot: I haz the power, 2017-03-28 01:29:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 01:35:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490664551714620,
"parent_rev": "b4bea78349858d797132879b14afe743703fefb2", "commit_rev":
"76ad12fee73e4512dbb9c7a79ffb6cec33fae6f2"}

[commit-bot: I haz the power, 2017-03-28 01:36:30]

Description was changed from

==========
Enable -Wdeprecated-register.

No behavior change.

BUG=255186
==========

to

==========
Enable -Wdeprecated-register.

No behavior change.

BUG=255186

Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
==========

[commit-bot: I haz the power, 2017-03-28 01:36:31]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...

[satorux1, 2017-03-28 01:58:23]

I got this error: crbug.com/705812

[satorux1, 2017-03-28 02:28:26]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2778053003/ by satorux@chromium.org.

The reason for reverting is: Broke os="chromeos" build: crbug.com/705812.

[Nico, 2017-03-28 14:58:52]

Description was changed from

==========
Enable -Wdeprecated-register.

No behavior change.

BUG=255186

Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
==========

to

==========
Enable -Wdeprecated-register (except on CrOS).

No behavior change.

BUG=255186

Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
==========

[Nico, 2017-03-28 14:59:39]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-28 14:59:39]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2780623003/#ps100001
(title: "...except on cros")

[commit-bot: I haz the power, 2017-03-28 15:00:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 15:04:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 15:04:11]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-03-28 15:14:49]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-28 15:14:50]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2780623003/#ps120001
(title: "how do i syntax")

[commit-bot: I haz the power, 2017-03-28 15:15:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-28 15:21:44]

Description was changed from

==========
Enable -Wdeprecated-register (except on CrOS).

No behavior change.

BUG=255186

Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
==========

to

==========
Enable -Wdeprecated-register (except on CrOS).

No behavior change.

BUG=255186,705812

Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
==========

[commit-bot: I haz the power, 2017-03-28 15:53:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 15:53:53]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[please use gerrit instead, 2017-03-28 16:16:39]

LGTM. Filed an issue upstream:
https://github.com/googlei18n/libaddressinput/issues/121

[Nico, 2017-03-30 17:04:52]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-30 17:05:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 21:16:23]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490893492331480,
"parent_rev": "f8d338ac684358b34a2cd77518d434fb6fa433a3", "commit_rev":
"a46872ca96d862816f993c16d6c270af26290247"}

[commit-bot: I haz the power, 2017-03-30 21:17:08]

Description was changed from

==========
Enable -Wdeprecated-register (except on CrOS).

No behavior change.

BUG=255186,705812

Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
==========

to

==========
Enable -Wdeprecated-register (except on CrOS).

No behavior change.

BUG=255186,705812

Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#460879}
Committed:
https://chromium.googlesource.com/chromium/src/+/a46872ca96d862816f993c16d6c2...
==========

[commit-bot: I haz the power, 2017-03-30 21:17:09]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/a46872ca96d862816f993c16d6c2...

[findit-for-me, 2017-03-30 22:49:15]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2786273002/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit identified CL at revision 460879 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

[Lei Zhang, 2017-03-30 23:36:58]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-03-30 23:36:59]

Failed on 32-bit Linux bots:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg...

FAILED: obj/third_party/pdfium/fpdfdoc/cpvt_fontmap.o 
In file included from ../../third_party/pdfium/core/fpdfdoc/cpvt_fontmap.cpp:9:
In file included from ../../third_party/pdfium/core/fpdfapi/font/cpdf_font.h:15:
In file included from ../../third_party/pdfium/core/fxge/fx_font.h:17:
In file included from ../../third_party/pdfium/core/fxge/fx_freetype.h:11:
In file included from
../../build/linux/debian_jessie_i386-sysroot/usr/include/freetype2/freetype.h:33:
../../build/linux/debian_jessie_i386-sysroot/usr/include/freetype2/config/ftconfig.h:453:5:
error: 'register' storage class specifier is deprecated and incompatible with
C++1z [-Werror,-Wdeprecated-register]
    register FT_Int32  result;
    ^~~~~~~~~

[Nico, 2017-03-31 00:38:37]

Description was changed from

==========
Enable -Wdeprecated-register (except on CrOS).

No behavior change.

BUG=255186,705812

Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#460879}
Committed:
https://chromium.googlesource.com/chromium/src/+/a46872ca96d862816f993c16d6c2...
==========

to

==========
Enable -Wdeprecated-register (except on CrOS and 32-bit Linux).

No behavior change.

BUG=255186,705812

Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#460879}
Committed:
https://chromium.googlesource.com/chromium/src/+/a46872ca96d862816f993c16d6c2...
==========

[Nico, 2017-03-31 00:41:27]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-31 00:41:27]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
rouslan@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2780623003/#ps140001
(title: "32-bit linux")

[commit-bot: I haz the power, 2017-03-31 00:42:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-03-31 00:55:52]

https://codereview.chromium.org/2780623003/diff/140001/build/config/compiler/...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2780623003/diff/140001/build/config/compiler/...
build/config/compiler/BUILD.gn:1075: # TODO(thakis): Remove from 32-bit Linux
eventually, https://707084
Missing crbug.com/

[Nico, 2017-03-31 01:22:59]

https://codereview.chromium.org/2780623003/diff/140001/build/config/compiler/...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2780623003/diff/140001/build/config/compiler/...
build/config/compiler/BUILD.gn:1075: # TODO(thakis): Remove from 32-bit Linux
eventually, https://707084
On 2017/03/31 00:55:52, Lei Zhang wrote:
> Missing crbug.com/

D'oh, will fix in follow up

[commit-bot: I haz the power, 2017-03-31 03:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 03:03:25]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Nico, 2017-03-31 10:08:37]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-31 10:08:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 10:16:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 10:16:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2017-03-31 10:31:43]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-31 10:31:43]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
rouslan@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2780623003/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-31 10:32:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 12:51:59]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1490956303228230,
"parent_rev": "b8a8a5c3a7ad034a074683ce7660138bd4326ac0", "commit_rev":
"755d274e7b3e893719322489b07a5d929328caa0"}

[commit-bot: I haz the power, 2017-03-31 12:52:52]

Description was changed from

==========
Enable -Wdeprecated-register (except on CrOS and 32-bit Linux).

No behavior change.

BUG=255186,705812

Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#460879}
Committed:
https://chromium.googlesource.com/chromium/src/+/a46872ca96d862816f993c16d6c2...
==========

to

==========
Enable -Wdeprecated-register (except on CrOS and 32-bit Linux).

No behavior change.

BUG=255186,705812

Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Original-Commit-Position: refs/heads/master@{#459973}
Committed:
https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb...
Review-Url: https://codereview.chromium.org/2780623003
Cr-Original-Commit-Position: refs/heads/master@{#460879}
Committed:
https://chromium.googlesource.com/chromium/src/+/a46872ca96d862816f993c16d6c2...
Review-Url: https://codereview.chromium.org/2780623003
Cr-Commit-Position: refs/heads/master@{#461102}
Committed:
https://chromium.googlesource.com/chromium/src/+/755d274e7b3e893719322489b07a...
==========

[commit-bot: I haz the power, 2017-03-31 12:52:57]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/755d274e7b3e893719322489b07a...