Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2777673003: Revert of Track telemetry benchmark cycle time (Closed)

Created:
3 years, 9 months ago by sullivan
Modified:
3 years, 9 months ago
Reviewers:
nednguyen, martiniss
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Track telemetry benchmark cycle time (patchset #5 id:80001 of https://codereview.chromium.org/2749633004/ ) Reason for revert: This is causing disabled tests to show up as red on perf waterfall. BUG=chromium:705251 Original issue's description: > Track telemetry benchmark cycle time > > BUG=chromium:700086 > > Review-Url: https://codereview.chromium.org/2749633004 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bb15ceda2809b58f629b173e0af7689261bdb915 TBR=nednguyen@google.com,martiniss@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:700086 Review-Url: https://codereview.chromium.org/2777673003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0cfeabf7007c77377dc389331d723d5e41d8c911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -58 lines) Patch
M telemetry/telemetry/internal/story_runner.py View 4 chunks +1 line, -6 lines 0 comments Download
M telemetry/telemetry/internal/story_runner_unittest.py View 6 chunks +2 lines, -47 lines 0 comments Download
M telemetry/telemetry/testing/fakes/__init__.py View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sullivan
Created Revert of Track telemetry benchmark cycle time
3 years, 9 months ago (2017-03-26 00:42:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777673003/1
3 years, 9 months ago (2017-03-26 00:42:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0cfeabf7007c77377dc389331d723d5e41d8c911
3 years, 9 months ago (2017-03-26 01:05:27 UTC) #6
martiniss
3 years, 9 months ago (2017-03-27 18:06:36 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2777093004/ by martiniss@chromium.org.

The reason for reverting is: Will fix CL.

Powered by Google App Engine
This is Rietveld 408576698