Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: telemetry/telemetry/internal/story_runner.py

Issue 2777673003: Revert of Track telemetry benchmark cycle time (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/internal/story_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/story_runner.py
diff --git a/telemetry/telemetry/internal/story_runner.py b/telemetry/telemetry/internal/story_runner.py
index 93242512fbb6aec2f51b5580563c4b4c1c987166..4242b78b8c85b08ca070dca31aac268441771299 100644
--- a/telemetry/telemetry/internal/story_runner.py
+++ b/telemetry/telemetry/internal/story_runner.py
@@ -24,7 +24,6 @@
from telemetry.util import wpr_modes
from telemetry.value import failure
from telemetry.value import skip
-from telemetry.value import scalar
from telemetry.web_perf import story_test
@@ -302,7 +301,6 @@
The number of failure values (up to 254) or 255 if there is an uncaught
exception.
"""
- start = time.time()
benchmark.CustomizeBrowserOptions(finder_options.browser_options)
benchmark_metadata = benchmark.GetMetadata()
@@ -328,7 +326,7 @@
results.PrintSummary()
# When a disabled benchmark is run we now want to return success since
# we are no longer filtering these out in the buildbot recipes.
- return 17
+ return 0
pt = benchmark.CreatePageTest(finder_options)
pt.__name__ = benchmark.__class__.__name__
@@ -377,9 +375,6 @@
results.UploadTraceFilesToCloud(bucket)
results.UploadProfilingFilesToCloud(bucket)
finally:
- duration = time.time() - start
- results.AddSummaryValue(scalar.ScalarValue(
- None, 'BenchmarkDuration', 'minutes', duration / 60.0))
results.PrintSummary()
return return_code
« no previous file with comments | « no previous file | telemetry/telemetry/internal/story_runner_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698