Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2777093004: Reland of Track telemetry benchmark cycle time (Closed)

Created:
3 years, 9 months ago by martiniss
Modified:
3 years, 8 months ago
Reviewers:
nednguyen, sullivan
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Reland of Track telemetry benchmark cycle time (patchset #1 id:1 of https://codereview.chromium.org/2777673003/ ) Reason for revert: Will fix CL Original issue's description: > Revert of Track telemetry benchmark cycle time (patchset #5 id:80001 of https://codereview.chromium.org/2749633004/ ) > > Reason for revert: > This is causing disabled tests to show up as red on perf waterfall. > > BUG=chromium:705251 > > Original issue's description: > > Track telemetry benchmark cycle time > > > > BUG=chromium:700086 > > > > Review-Url: https://codereview.chromium.org/2749633004 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bb15ceda2809b58f629b173e0af7689261bdb915 > > TBR=nednguyen@google.com,martiniss@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:700086 > > Review-Url: https://codereview.chromium.org/2777673003 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0cfeabf7007c77377dc389331d723d5e41d8c911 TBR=nednguyen@google.com,sullivan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:705251 Review-Url: https://codereview.chromium.org/2777093004 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9b208c6704237b0d7ea91275f5c9b1d414585ca3

Patch Set 1 #

Patch Set 2 : Fix bad return #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -4 lines) Patch
M telemetry/telemetry/internal/story_runner.py View 1 3 chunks +5 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/story_runner_unittest.py View 1 6 chunks +47 lines, -2 lines 0 comments Download
M telemetry/telemetry/testing/fakes/__init__.py View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
martiniss
Created Reland of Track telemetry benchmark cycle time
3 years, 9 months ago (2017-03-27 18:06:36 UTC) #1
martiniss
Fixed the bad line. We should probably test this method more than it is now; ...
3 years, 9 months ago (2017-03-27 18:10:34 UTC) #2
nednguyen
On 2017/03/27 18:10:34, martiniss wrote: > Fixed the bad line. > > We should probably ...
3 years, 9 months ago (2017-03-27 21:20:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777093004/100001
3 years, 8 months ago (2017-03-28 21:26:25 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 21:48:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698