Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2777393002: Revert of Initialize ChildMemoryCoordinator before blink (Closed)

Created:
3 years, 9 months ago by bashi
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Initialize ChildMemoryCoordinator before blink (patchset #3 id:40001 of https://codereview.chromium.org/2775583002/ ) Reason for revert: This caused renderer crashes. BUG=705021 Original issue's description: > Initialize ChildMemoryCoordinator before blink > > Some features of memory coordinator will be exposed to v8. We should > initialize ChildMemoryCoordinator before blink to make sure that v8 > can access memory coordinator features from the beginning. > > BUG=693430 > > Review-Url: https://codereview.chromium.org/2775583002 > Cr-Commit-Position: refs/heads/master@{#459308} > Committed: https://chromium.googlesource.com/chromium/src/+/d43ce5d5dc0b568a1c0ec616012ebc38e9d9e8b3 TBR=haraken@chromium.org,avi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=693430 Review-Url: https://codereview.chromium.org/2777393002 Cr-Commit-Position: refs/heads/master@{#459996} Committed: https://chromium.googlesource.com/chromium/src/+/296ebdae36af19a38f2356b28c70f27fa71a89ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M content/renderer/render_thread_impl.cc View 2 chunks +19 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bashi
Created Revert of Initialize ChildMemoryCoordinator before blink
3 years, 9 months ago (2017-03-28 00:39:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777393002/1
3 years, 9 months ago (2017-03-28 00:40:38 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-28 01:36:46 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 03:28:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/296ebdae36af19a38f2356b28c70...

Powered by Google App Engine
This is Rietveld 408576698