Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 2775583002: Initialize ChildMemoryCoordinator before blink (Closed)

Created:
3 years, 9 months ago by bashi
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize ChildMemoryCoordinator before blink Some features of memory coordinator will be exposed to v8. We should initialize ChildMemoryCoordinator before blink to make sure that v8 can access memory coordinator features from the beginning. BUG=693430 Review-Url: https://codereview.chromium.org/2775583002 Cr-Commit-Position: refs/heads/master@{#459308} Committed: https://chromium.googlesource.com/chromium/src/+/d43ce5d5dc0b568a1c0ec616012ebc38e9d9e8b3

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M content/renderer/render_thread_impl.cc View 1 2 2 chunks +16 lines, -19 lines 1 comment Download

Messages

Total messages: 27 (19 generated)
bashi
PTAL This is a part of https://codereview.chromium.org/2731913002/. I want to make the WIP CL as ...
3 years, 9 months ago (2017-03-23 07:19:20 UTC) #5
bashi
https://codereview.chromium.org/2775583002/diff/40001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (left): https://codereview.chromium.org/2775583002/diff/40001/content/renderer/render_thread_impl.cc#oldcode836 content/renderer/render_thread_impl.cc:836: // TODO(bashi): Revisit how to manage the lifetime of ...
3 years, 9 months ago (2017-03-23 07:47:52 UTC) #15
haraken
LGTM
3 years, 9 months ago (2017-03-23 08:09:20 UTC) #16
bashi
+avi@ for content/ OWNERs review
3 years, 9 months ago (2017-03-23 23:10:21 UTC) #20
Avi (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-24 00:03:47 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775583002/40001
3 years, 9 months ago (2017-03-24 00:07:47 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d43ce5d5dc0b568a1c0ec616012ebc38e9d9e8b3
3 years, 9 months ago (2017-03-24 00:52:11 UTC) #26
bashi
3 years, 9 months ago (2017-03-28 00:39:58 UTC) #27
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2777393002/ by bashi@chromium.org.

The reason for reverting is: This caused renderer crashes.

crbug.com/705021
.

Powered by Google App Engine
This is Rietveld 408576698