|
|
DescriptionInitialize ChildMemoryCoordinator before blink
Some features of memory coordinator will be exposed to v8. We should
initialize ChildMemoryCoordinator before blink to make sure that v8
can access memory coordinator features from the beginning.
BUG=693430
Review-Url: https://codereview.chromium.org/2775583002
Cr-Commit-Position: refs/heads/master@{#459308}
Committed: https://chromium.googlesource.com/chromium/src/+/d43ce5d5dc0b568a1c0ec616012ebc38e9d9e8b3
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #
Total comments: 1
Messages
Total messages: 27 (19 generated)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bashi@chromium.org changed reviewers: + haraken@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
PTAL This is a part of https://codereview.chromium.org/2731913002/. I want to make the WIP CL as small as possible.
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2775583002/diff/40001/content/renderer/render... File content/renderer/render_thread_impl.cc (left): https://codereview.chromium.org/2775583002/diff/40001/content/renderer/render... content/renderer/render_thread_impl.cc:836: // TODO(bashi): Revisit how to manage the lifetime of Removed this TODO as this looks a common pattern to bind interface.
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
bashi@chromium.org changed reviewers: + avi@chromium.org
+avi@ for content/ OWNERs review
lgtm
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490314035090150, "parent_rev": "d604de96c960021b33f929e9cdf9eca8079ad92b", "commit_rev": "d43ce5d5dc0b568a1c0ec616012ebc38e9d9e8b3"}
Message was sent while issue was closed.
Description was changed from ========== Initialize ChildMemoryCoordinator before blink Some features of memory coordinator will be exposed to v8. We should initialize ChildMemoryCoordinator before blink to make sure that v8 can access memory coordinator features from the beginning. BUG=693430 ========== to ========== Initialize ChildMemoryCoordinator before blink Some features of memory coordinator will be exposed to v8. We should initialize ChildMemoryCoordinator before blink to make sure that v8 can access memory coordinator features from the beginning. BUG=693430 Review-Url: https://codereview.chromium.org/2775583002 Cr-Commit-Position: refs/heads/master@{#459308} Committed: https://chromium.googlesource.com/chromium/src/+/d43ce5d5dc0b568a1c0ec616012e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d43ce5d5dc0b568a1c0ec616012e...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2777393002/ by bashi@chromium.org. The reason for reverting is: This caused renderer crashes. crbug.com/705021 . |