chromeos: Update note-taking apps when ARC-enabled profile added.

chromeos: Update note-taking apps when ARC-enabled profile added.

Make NoteTakingHelper check new profiles' Play-Store-enabled
states when they're added. It appears that
OnArcPlayStoreEnabledChanged() is now not called in this
case, resulting in the list of Android note-taking apps
sometimes not being updated after login.

BUG=700554
Review-Url: https://codereview.chromium.org/2777253002
Cr-Commit-Position: refs/heads/master@{#459921}
Committed: https://chromium.googlesource.com/chromium/src/+/e96743eac963561dec6ec4d0f07f647cb27bc380

[Daniel Erat, 2017-03-27 19:25:23]

derat@chromium.org changed reviewers:
+ jdufault@chromium.org, kinaba@chromium.org, yusukes@chromium.org

[Daniel Erat, 2017-03-27 19:25:24]

https://codereview.chromium.org/2777253002/diff/1/chrome/browser/chromeos/not...
File chrome/browser/chromeos/note_taking_helper.cc (right):

https://codereview.chromium.org/2777253002/diff/1/chrome/browser/chromeos/not...
chrome/browser/chromeos/note_taking_helper.cc:404:
observer.OnAvailableNoteTakingAppsUpdated();
this notification is since we're now waiting for android apps. it's covered by
tests, but let me know if you think this also justifies a comment here.

[Daniel Erat, 2017-03-27 19:25:28]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 19:26:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-03-27 20:00:42]

Since the bug is RBS lgtm, but I think we should create a new bug documenting
the issue with OnArcPlayStoreEnabledChanged and remove the workaround (add a
TODO?) once the real problem gets fixed.

[commit-bot: I haz the power, 2017-03-27 20:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 20:08:44]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2017-03-27 21:38:48]

Unblocking the release with this workaround seems fine (so lgtm) but we should
fix the root cause... I'll comment on the bug shortly.

https://codereview.chromium.org/2777253002/diff/1/chrome/browser/chromeos/not...
File chrome/browser/chromeos/note_taking_helper.cc (right):

https://codereview.chromium.org/2777253002/diff/1/chrome/browser/chromeos/not...
chrome/browser/chromeos/note_taking_helper.cc:401: if (!play_store_enabled_ &&
arc::IsArcPlayStoreEnabledForProfile(profile)) {
+1 for adding a TODO here. TODO(hidehiko) should be fine.

I tested tot Chrome, and in my case,
NoteTakingHelper::OnArcPlayStoreEnabledChanged() *is* always called shortly
after signing in. If there's a case where the callback is never called, we
should fix it.

[Daniel Erat, 2017-03-27 22:04:16]

https://codereview.chromium.org/2777253002/diff/1/chrome/browser/chromeos/not...
File chrome/browser/chromeos/note_taking_helper.cc (right):

https://codereview.chromium.org/2777253002/diff/1/chrome/browser/chromeos/not...
chrome/browser/chromeos/note_taking_helper.cc:401: if (!play_store_enabled_ &&
arc::IsArcPlayStoreEnabledForProfile(profile)) {
On 2017/03/27 21:38:47, Yusuke Sato wrote:
> +1 for adding a TODO here. TODO(hidehiko) should be fine.
> 
> I tested tot Chrome, and in my case,
> NoteTakingHelper::OnArcPlayStoreEnabledChanged() *is* always called shortly
> after signing in. If there's a case where the callback is never called, we
> should fix it.

Done.

[Daniel Erat, 2017-03-27 22:04:20]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2017-03-27 22:04:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org, yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2777253002/#ps20001
(title: "add TODO")

[commit-bot: I haz the power, 2017-03-27 22:05:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 22:58:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490652260730880,
"parent_rev": "119e4c228dd58f8b754735f92cb7e31e999e01de", "commit_rev":
"e96743eac963561dec6ec4d0f07f647cb27bc380"}

[commit-bot: I haz the power, 2017-03-27 22:59:17]

Description was changed from

==========
chromeos: Update note-taking apps when ARC-enabled profile added.

Make NoteTakingHelper check new profiles' Play-Store-enabled
states when they're added. It appears that
OnArcPlayStoreEnabledChanged() is now not called in this
case, resulting in the list of Android note-taking apps
sometimes not being updated after login.

BUG=700554
==========

to

==========
chromeos: Update note-taking apps when ARC-enabled profile added.

Make NoteTakingHelper check new profiles' Play-Store-enabled
states when they're added. It appears that
OnArcPlayStoreEnabledChanged() is now not called in this
case, resulting in the list of Android note-taking apps
sometimes not being updated after login.

BUG=700554

Review-Url: https://codereview.chromium.org/2777253002
Cr-Commit-Position: refs/heads/master@{#459921}
Committed:
https://chromium.googlesource.com/chromium/src/+/e96743eac963561dec6ec4d0f07f...
==========

[commit-bot: I haz the power, 2017-03-27 22:59:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e96743eac963561dec6ec4d0f07f...