Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: chrome/browser/chromeos/note_taking_helper_unittest.cc

Issue 2777253002: chromeos: Update note-taking apps when ARC-enabled profile added. (Closed)
Patch Set: add TODO Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/note_taking_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/note_taking_helper_unittest.cc
diff --git a/chrome/browser/chromeos/note_taking_helper_unittest.cc b/chrome/browser/chromeos/note_taking_helper_unittest.cc
index 217ec7733c8bf552067a4305edc5ff325b94c17a..737ce3904c2317da7c47545fb1d8a2b68ea765ba 100644
--- a/chrome/browser/chromeos/note_taking_helper_unittest.cc
+++ b/chrome/browser/chromeos/note_taking_helper_unittest.cc
@@ -11,13 +11,16 @@
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
+#include "base/strings/utf_string_conversions.h"
#include "base/test/histogram_tester.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/chromeos/file_manager/path_util.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/test_extension_system.h"
+#include "chrome/browser/prefs/browser_prefs.h"
#include "chrome/browser/ui/app_list/arc/arc_app_test.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/browser_with_test_window_test.h"
@@ -31,6 +34,7 @@
#include "components/arc/common/intent_helper.mojom.h"
#include "components/arc/test/fake_intent_helper_instance.h"
#include "components/crx_file/id_util.h"
+#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_source.h"
#include "extensions/common/api/app_runtime.h"
@@ -497,6 +501,41 @@ TEST_P(NoteTakingHelperTest, PlayStoreInitiallyDisabled) {
EXPECT_TRUE(helper()->android_apps_received());
}
+TEST_P(NoteTakingHelperTest, AddProfileWithPlayStoreEnabled) {
+ Init(ENABLE_PALETTE);
+ EXPECT_FALSE(helper()->play_store_enabled());
+ EXPECT_FALSE(helper()->android_apps_received());
+
+ TestObserver observer;
+ ASSERT_EQ(0, observer.num_updates());
+
+ // Add a second profile with the ARC-enabled pref already set. The Play Store
+ // should be immediately regarded as being enabled and the observer should be
+ // notified, since OnArcPlayStoreEnabledChanged() apparently isn't called in
+ // this case: http://crbug.com/700554
+ const char kSecondProfileName[] = "second-profile";
+ auto prefs = base::MakeUnique<sync_preferences::TestingPrefServiceSyncable>();
+ chrome::RegisterUserProfilePrefs(prefs->registry());
+ prefs->SetBoolean(prefs::kArcEnabled, true);
+ profile_manager_->CreateTestingProfile(
+ kSecondProfileName, std::move(prefs), base::ASCIIToUTF16("Second User"),
+ 1 /* avatar_id */, std::string() /* supervised_user_id */,
+ TestingProfile::TestingFactories());
+ EXPECT_TRUE(helper()->play_store_enabled());
+ EXPECT_FALSE(helper()->android_apps_received());
+ EXPECT_EQ(1, observer.num_updates());
+
+ // Notification of updated intent filters should result in the apps being
+ // refreshed.
+ helper()->OnIntentFiltersUpdated();
+ base::RunLoop().RunUntilIdle();
+ EXPECT_TRUE(helper()->play_store_enabled());
+ EXPECT_TRUE(helper()->android_apps_received());
+ EXPECT_EQ(2, observer.num_updates());
+
+ profile_manager_->DeleteTestingProfile(kSecondProfileName);
+}
+
TEST_P(NoteTakingHelperTest, ListAndroidApps) {
// Add two Android apps.
std::vector<IntentHandlerInfoPtr> handlers;
« no previous file with comments | « chrome/browser/chromeos/note_taking_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698