chromeos: Update note-taking apps when ARC-enabled profile added.

chrome/browser/chromeos/note_taking_helper.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/note_taking_helper.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "apps/launcher.h"
@@ skipping 373 matching lines @@
     launch_chrome_app_callback_.Run(profile, app, std::move(action_data), path);
     return LaunchResult::CHROME_SUCCESS;
   }
   NOTREACHED();
 }
 
 void NoteTakingHelper::Observe(int type,
                                const content::NotificationSource& source,
                                const content::NotificationDetails& details) {
   DCHECK_EQ(type, chrome::NOTIFICATION_PROFILE_ADDED);
-  auto* registry = extensions::ExtensionRegistry::Get(
-      content::Source<Profile>(source).ptr());
+  Profile* profile = content::Source<Profile>(source).ptr();
+  DCHECK(profile);
+
+  auto* registry = extensions::ExtensionRegistry::Get(profile);
   DCHECK(!extension_registry_observer_.IsObserving(registry));
   extension_registry_observer_.Add(registry);
+
+  if (!play_store_enabled_ && arc::IsArcPlayStoreEnabledForProfile(profile)) {

[Yusuke Sato, 2017/03/27 21:38:47]

+1 for adding a TODO here. TODO(hidehiko) should be fine.

I tested tot Chrome, and in my case,
NoteTakingHelper::OnArcPlayStoreEnabledChanged() *is* always called shortly
after signing in. If there's a case where the callback is never called, we
should fix it.

[Daniel Erat, 2017/03/27 22:04:16]

Done.

+    play_store_enabled_ = true;
+    for (auto& observer : observers_)
+      observer.OnAvailableNoteTakingAppsUpdated();

[Daniel Erat, 2017/03/27 19:25:23]

this notification is since we're now waiting for android apps. it's covered by
tests, but let me know if you think this also justifies a comment here.

+  }
 }
 
 void NoteTakingHelper::OnExtensionLoaded(
     content::BrowserContext* browser_context,
     const extensions::Extension* extension) {
   if (IsWhitelistedChromeApp(extension) ||
       extensions::ActionHandlersInfo::HasActionHandler(
           extension, app_runtime::ACTION_TYPE_NEW_NOTE)) {
     for (auto& observer : observers_)
       observer.OnAvailableNoteTakingAppsUpdated();
@@ skipping 10 matching lines @@
     for (auto& observer : observers_)
       observer.OnAvailableNoteTakingAppsUpdated();
   }
 }
 
 void NoteTakingHelper::OnShutdown(extensions::ExtensionRegistry* registry) {
   extension_registry_observer_.Remove(registry);
 }
 
 }  // namespace chromeos