Add logging for logdog link to logcat.

Add logging for logdog link to logcat.

Currently, logcats are very difficult to find in bot logs. Adding
logging to log the logdog links.

In the future, these links will get moved out of the python logs
and into the result detail HTML page.

Review-Url: https://codereview.chromium.org/2777103004
Cr-Commit-Position: refs/heads/master@{#460151}
Committed: https://chromium.googlesource.com/chromium/src/+/2753f4dd3d49fddb16c538feddb125c92cc0fe23

[mikecase (-- gone --), 2017-03-28 01:05:58]

mikecase@chromium.org changed reviewers:
+ hzl@chromium.org, jbudorick@chromium.org

[mikecase (-- gone --), 2017-03-28 01:05:58]

I *think* the logcats are currently being recorded but that the links are not
logged anywhere. That is my theory anyway. Running tryjob, and if I see the
logcat links appear, would like to commit this CL.

[jbudorick, 2017-03-28 01:09:21]

lgtm w/ q if the logcatdog links show up

https://codereview.chromium.org/2777103004/diff/1/build/android/test_runner.py
File build/android/test_runner.py (right):

https://codereview.chromium.org/2777103004/diff/1/build/android/test_runner.p...
build/android/test_runner.py:756: dst =
logdog_helper.open_text('unified_logcats')
hrm, should this be

  with logdog_helper.text('unified_logcats') as dst:
    ...
  logging.critical(...)

?

[mikecase (-- gone --), 2017-03-28 15:39:51]

verified we get the logcat link printed out with this. And do not get a logcat
link without this.

https://codereview.chromium.org/2777103004/diff/1/build/android/test_runner.py
File build/android/test_runner.py (right):

https://codereview.chromium.org/2777103004/diff/1/build/android/test_runner.p...
build/android/test_runner.py:756: dst =
logdog_helper.open_text('unified_logcats')
On 2017/03/28 at 01:09:21, jbudorick wrote:
> hrm, should this be
> 
>   with logdog_helper.text('unified_logcats') as dst:
>     ...
>   logging.critical(...)
> 
> ?

logdog_helper.text isnt a contextmanager. So that won't work. It looks like it
should work that way though. May clean up in future.

[mikecase (-- gone --), 2017-03-28 15:40:13]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2017-03-28 15:40:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-03-28 15:41:27]

https://codereview.chromium.org/2777103004/diff/1/build/android/test_runner.py
File build/android/test_runner.py (right):

https://codereview.chromium.org/2777103004/diff/1/build/android/test_runner.p...
build/android/test_runner.py:756: dst =
logdog_helper.open_text('unified_logcats')
On 2017/03/28 15:39:51, mikecase wrote:
> On 2017/03/28 at 01:09:21, jbudorick wrote:
> > hrm, should this be
> > 
> >   with logdog_helper.text('unified_logcats') as dst:
> >     ...
> >   logging.critical(...)
> > 
> > ?
> 
> logdog_helper.text isnt a contextmanager. So that won't work. It looks like it
> should work that way though. May clean up in future.

ah, my mistake. I was looking at the underlying client.

[commit-bot: I haz the power, 2017-03-28 17:22:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490715613138610, "parent_rev":
"9c1b2cf6351dc1eb740bce11c620f5566042e11f", "commit_rev":
"2753f4dd3d49fddb16c538feddb125c92cc0fe23"}

[commit-bot: I haz the power, 2017-03-28 17:23:26]

Description was changed from

==========
Add logging for logdog link to logcat.

Currently, logcats are very difficult to find in bot logs. Adding
logging to log the logdog links.

In the future, these links will get moved out of the python logs
and into the result detail HTML page.
==========

to

==========
Add logging for logdog link to logcat.

Currently, logcats are very difficult to find in bot logs. Adding
logging to log the logdog links.

In the future, these links will get moved out of the python logs
and into the result detail HTML page.

Review-Url: https://codereview.chromium.org/2777103004
Cr-Commit-Position: refs/heads/master@{#460151}
Committed:
https://chromium.googlesource.com/chromium/src/+/2753f4dd3d49fddb16c538feddb1...
==========

[commit-bot: I haz the power, 2017-03-28 17:23:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2753f4dd3d49fddb16c538feddb1...