Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: build/android/test_runner.py

Issue 2777103004: Add logging for logdog link to logcat. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/utils/logdog_helper.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/test_runner.py
diff --git a/build/android/test_runner.py b/build/android/test_runner.py
index deacc6c07370160db9d154cfc330fae741a0af24..cb2767e662415d00f49b3341f9a0109ec415c47d 100755
--- a/build/android/test_runner.py
+++ b/build/android/test_runner.py
@@ -756,6 +756,10 @@ def RunTestsInPlatformMode(args):
dst = logdog_helper.open_text('unified_logcats')
jbudorick 2017/03/28 01:09:21 hrm, should this be with logdog_helper.text('un
mikecase (-- gone --) 2017/03/28 15:39:51 logdog_helper.text isnt a contextmanager. So that
jbudorick 2017/03/28 15:41:27 ah, my mistake. I was looking at the underlying cl
if dst:
shutil.copyfileobj(src, dst)
+ dst.close()
+ logging.critical(
+ 'Logcat: %s', logdog_helper.get_viewer_url('unified_logcats'))
+
logcats_uploader = contextlib_ext.Optional(
upload_logcats_file(),
« no previous file with comments | « build/android/pylib/utils/logdog_helper.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698