Add logging for logdog link to logcat.

build/android/test_runner.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs all types of tests from one unified interface."""
 
 import argparse
 import collections
@@ skipping 735 matching lines @@
   @contextlib.contextmanager
   def upload_logcats_file():
     try:
       yield
     finally:
       if not args.logcat_output_file:
         logging.critical('Cannot upload logcats file. '
                         'File to save logcat is not specified.')
       else:
         with open(args.logcat_output_file) as src:
           dst = logdog_helper.open_text('unified_logcats')

[jbudorick, 2017/03/28 01:09:21]

hrm, should this be

  with logdog_helper.text('unified_logcats') as dst:
    ...
  logging.critical(...)

?

[mikecase (-- gone --), 2017/03/28 15:39:51]

logdog_helper.text isnt a contextmanager. So that won't work. It looks like it
should work that way though. May clean up in future.

[jbudorick, 2017/03/28 15:41:27]

ah, my mistake. I was looking at the underlying client.

           if dst:
             shutil.copyfileobj(src, dst)
+            dst.close()
+            logging.critical(
+                'Logcat: %s', logdog_helper.get_viewer_url('unified_logcats'))
+
 
   logcats_uploader = contextlib_ext.Optional(
       upload_logcats_file(),
       'upload_logcats_file' in args and args.upload_logcats_file)
 
   ### Set up test objects.
 
   env = environment_factory.CreateEnvironment(args, infra_error)
   test_instance = test_instance_factory.CreateTestInstance(args, infra_error)
   test_run = test_run_factory.CreateTestRun(
@@ skipping 143 matching lines @@
     if e.is_infra_error:
       return constants.INFRA_EXIT_CODE
     return constants.ERROR_EXIT_CODE
   except: # pylint: disable=W0702
     logging.exception('Unrecognized error occurred.')
     return constants.ERROR_EXIT_CODE
 
 
 if __name__ == '__main__':
   sys.exit(main())