Change rebaseline-test-internal to take port name option.

Change rebaseline-test-internal to take port name option.

This CL changes `webkit-patch rebaseline-test-internal` to take a port
name in addition to a builder name. The builder name determines where
to pull the result from, and the port name determines what port the
new baseline belongs to.

The purpose of this change is to make it so that that baselines can
be downloaded from a builder that does not necessarily correspond
to the port that the baseline is for (see point 2 in http://crbug.com/673966#c3).

In addition, this CL also changes some related things for consistency:
 - webkit-patch copy-existing-baselines-internal takes a port instead
   of builder name; previously it had just used the builder name
   to get a Port.
 - The order of the arguments passed to these functions is changed and
   made more consistent.
 - The formatting of the command arguments in the tests is cleaned up.
 - The MockLineRemovingExecutive in rebaseline_unittest is changed.

BUG=673966
Review-Url: https://codereview.chromium.org/2776543003
Cr-Commit-Position: refs/heads/master@{#459573}
Committed: https://chromium.googlesource.com/chromium/src/+/3c6862c764ace98c3075f88f862f888bad739494

[qyearsley, 2017-03-24 01:42:58]

Description was changed from

==========
Change internal rebaseline commands to take port-name option.

BUG=673966
==========

to

==========
Change internal rebaseline commands to take port-name option.

Summary: This CL changes webkit-patch rebaseline-test-internal and
copy-existing-baselines-internal to take...

This CL:

BUG=673966
==========

[qyearsley, 2017-03-24 17:18:34]

Description was changed from

==========
Change internal rebaseline commands to take port-name option.

Summary: This CL changes webkit-patch rebaseline-test-internal and
copy-existing-baselines-internal to take...

This CL:

BUG=673966
==========

to

==========
Change rebaseline-test-internal to take port name option.

This CL changes `webkit-patch rebaseline-test-internal` to take a port
name in addition to a builder name. The builder name determines where
to pull the result from, and the port name determines what port the
new baseline belongs to.

The purpose of this change is to make it so that that baselines can
be downloaded from a builder that does not necessarily correspond
to the port that the baseline is for (see point 2 in
http://crbug.com/673966#c3).

In addition, this CL also changes some related things for consistency:
 - webkit-patch copy-existing-baselines-internal takes a port instead
   of builder name; previously it had just used the builder name
   to get a Port.
 - The order of the arguments passed to these functions is changed and
   made more consistent.
 - The formatting of the command arguments in the tests is cleaned up.
 - The MockLineRemovingExecutive in rebaseline_unittest is changed.

BUG=673966
==========

[qyearsley, 2017-03-24 17:18:34]

qyearsley@chromium.org changed reviewers:
+ wkorman@chromium.org

[qyearsley, 2017-03-24 17:18:38]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 17:19:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 18:20:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 18:20:14]

Dry run: This issue passed the CQ dry run.

[wkorman, 2017-03-24 18:56:05]

lgtm

https://codereview.chromium.org/2776543003/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
(right):

https://codereview.chromium.org/2776543003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py:70: 'If
not given, this is determined based on --builder.'))
Maybe include an example value for people unfamiliar with builder names, port
names, etc.

[qyearsley, 2017-03-24 21:10:59]

https://codereview.chromium.org/2776543003/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
(right):

https://codereview.chromium.org/2776543003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py:70: 'If
not given, this is determined based on --builder.'))
On 2017/03/24 at 18:56:05, wkorman wrote:
> Maybe include an example value for people unfamiliar with builder names, port
names, etc.

Sounds good. In this case, --port-name is only used for "internal" commands that
are not intended to be directly invoked, but still things are generally clearer
with examples. Updated in latest patchset.

[qyearsley, 2017-03-24 21:11:00]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-03-24 21:11:01]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2776543003/#ps40001
(title: "Add example port name and builder in help strings")

[commit-bot: I haz the power, 2017-03-24 21:11:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 22:17:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490389860952110,
"parent_rev": "cd0b7b2029d532fd338ee0e5e7839987895971ab", "commit_rev":
"3c6862c764ace98c3075f88f862f888bad739494"}

[commit-bot: I haz the power, 2017-03-24 22:18:03]

Description was changed from

==========
Change rebaseline-test-internal to take port name option.

This CL changes `webkit-patch rebaseline-test-internal` to take a port
name in addition to a builder name. The builder name determines where
to pull the result from, and the port name determines what port the
new baseline belongs to.

The purpose of this change is to make it so that that baselines can
be downloaded from a builder that does not necessarily correspond
to the port that the baseline is for (see point 2 in
http://crbug.com/673966#c3).

In addition, this CL also changes some related things for consistency:
 - webkit-patch copy-existing-baselines-internal takes a port instead
   of builder name; previously it had just used the builder name
   to get a Port.
 - The order of the arguments passed to these functions is changed and
   made more consistent.
 - The formatting of the command arguments in the tests is cleaned up.
 - The MockLineRemovingExecutive in rebaseline_unittest is changed.

BUG=673966
==========

to

==========
Change rebaseline-test-internal to take port name option.

This CL changes `webkit-patch rebaseline-test-internal` to take a port
name in addition to a builder name. The builder name determines where
to pull the result from, and the port name determines what port the
new baseline belongs to.

The purpose of this change is to make it so that that baselines can
be downloaded from a builder that does not necessarily correspond
to the port that the baseline is for (see point 2 in
http://crbug.com/673966#c3).

In addition, this CL also changes some related things for consistency:
 - webkit-patch copy-existing-baselines-internal takes a port instead
   of builder name; previously it had just used the builder name
   to get a Port.
 - The order of the arguments passed to these functions is changed and
   made more consistent.
 - The formatting of the command arguments in the tests is cleaned up.
 - The MockLineRemovingExecutive in rebaseline_unittest is changed.

BUG=673966

Review-Url: https://codereview.chromium.org/2776543003
Cr-Commit-Position: refs/heads/master@{#459573}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c6862c764ace98c3075f88f862f...
==========

[commit-bot: I haz the power, 2017-03-24 22:18:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3c6862c764ace98c3075f88f862f...