Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Issue 2776543003: Change rebaseline-test-internal to take port name option. (Closed)
Patch Set: Add example port name and builder in help strings Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
index 56ec066b44240e5358c9ad6e4c5e343c67053ff5..a01849505d6596040df1996af137306394e2674a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
@@ -272,11 +272,25 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):
self.assertEqual(
self.tool.executive.calls,
[
- [['python', 'echo', 'copy-existing-baselines-internal', '--suffixes', 'txt',
- '--builder', 'MOCK Try Win', '--test', 'fast/dom/prototype-taco.html']],
- [['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt',
- '--builder', 'MOCK Try Win', '--test', 'fast/dom/prototype-taco.html', '--build-number', '5000']],
- [['python', 'echo', 'optimize-baselines', '--suffixes', 'txt', 'fast/dom/prototype-taco.html']]
+ [[
+ 'python', 'echo', 'copy-existing-baselines-internal',
+ '--test', 'fast/dom/prototype-taco.html',
+ '--suffixes', 'txt',
+ '--port-name', 'test-win-win7',
+ ]],
+ [[
+ 'python', 'echo', 'rebaseline-test-internal',
+ '--test', 'fast/dom/prototype-taco.html',
+ '--suffixes', 'txt',
+ '--port-name', 'test-win-win7',
+ '--builder', 'MOCK Try Win',
+ '--build-number', '5000',
+ ]],
+ [[
+ 'python', 'echo', 'optimize-baselines',
+ '--suffixes', 'txt',
+ 'fast/dom/prototype-taco.html',
+ ]]
])
def test_trigger_builds(self):

Powered by Google App Engine
This is Rietveld 408576698