Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py

Issue 2776543003: Change rebaseline-test-internal to take port name option. (Closed)
Patch Set: Add example port name and builder in help strings Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py
index a70786da0e307d7955392d317f11eed52ed3fc17..d97cae3a0bcdfbacfa9d46e6dafa531aadc03fbc 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py
@@ -228,22 +228,46 @@ crbug.com/24182 path/to/locally-changed-lined.html [ NeedsRebaseline ]
self.assertEqual(self.tool.executive.calls, [
[
- ['python', 'echo', 'copy-existing-baselines-internal', '--suffixes', 'png',
- '--builder', 'MOCK Mac10.11', '--test', 'fast/dom/prototype-strawberry.html'],
- ['python', 'echo', 'copy-existing-baselines-internal', '--suffixes', 'txt',
- '--builder', 'MOCK Mac10.11', '--test', 'fast/dom/prototype-taco.html'],
+ [
+ 'python', 'echo', 'copy-existing-baselines-internal',
+ '--test', 'fast/dom/prototype-strawberry.html',
+ '--suffixes', 'png',
+ '--port-name', 'test-mac-mac10.11',
+ ],
+ [
+ 'python', 'echo', 'copy-existing-baselines-internal',
+ '--test', 'fast/dom/prototype-taco.html',
+ '--suffixes', 'txt',
+ '--port-name', 'test-mac-mac10.11',
+ ],
],
[
- ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'png',
- '--builder', 'MOCK Mac10.11', '--test', 'fast/dom/prototype-strawberry.html'],
- ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt',
- '--builder', 'MOCK Mac10.11', '--test', 'fast/dom/prototype-taco.html'],
+ [
+ 'python', 'echo', 'rebaseline-test-internal',
+ '--test', 'fast/dom/prototype-strawberry.html',
+ '--suffixes', 'png',
+ '--port-name', 'test-mac-mac10.11',
+ '--builder', 'MOCK Mac10.11',
+ ],
+ [
+ 'python', 'echo', 'rebaseline-test-internal',
+ '--test', 'fast/dom/prototype-taco.html',
+ '--suffixes', 'txt',
+ '--port-name', 'test-mac-mac10.11',
+ '--builder', 'MOCK Mac10.11',
+ ],
],
[
- ['python', 'echo', 'optimize-baselines',
- '--suffixes', 'png', 'fast/dom/prototype-strawberry.html'],
- ['python', 'echo', 'optimize-baselines',
- '--suffixes', 'txt', 'fast/dom/prototype-taco.html'],
+ [
+ 'python', 'echo', 'optimize-baselines',
+ '--suffixes', 'png',
+ 'fast/dom/prototype-strawberry.html',
+ ],
+ [
+ 'python', 'echo', 'optimize-baselines',
+ '--suffixes', 'txt',
+ 'fast/dom/prototype-taco.html',
+ ],
],
['git', 'cl', 'upload', '-f'],
['git', 'pull'],
@@ -302,11 +326,24 @@ Bug(foo) fast/dom/prototype-taco.html [ NeedsRebaseline ]
self._execute_with_mock_options()
self.assertEqual(self.tool.executive.calls, [
- [['python', 'echo', 'copy-existing-baselines-internal', '--suffixes', 'txt',
- '--builder', 'MOCK Mac10.11', '--test', 'fast/dom/prototype-taco.html']],
- [['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt',
- '--builder', 'MOCK Mac10.11', '--test', 'fast/dom/prototype-taco.html']],
- [['python', 'echo', 'optimize-baselines', '--suffixes', 'txt', 'fast/dom/prototype-taco.html']],
+ [[
+ 'python', 'echo', 'copy-existing-baselines-internal',
+ '--test', 'fast/dom/prototype-taco.html',
+ '--suffixes', 'txt',
+ '--port-name', 'test-mac-mac10.11',
+ ]],
+ [[
+ 'python', 'echo', 'rebaseline-test-internal',
+ '--test', 'fast/dom/prototype-taco.html',
+ '--suffixes', 'txt',
+ '--port-name', 'test-mac-mac10.11',
+ '--builder', 'MOCK Mac10.11',
+ ]],
+ [[
+ 'python', 'echo', 'optimize-baselines',
+ '--suffixes', 'txt',
+ 'fast/dom/prototype-taco.html',
+ ]],
['git', 'cl', 'upload', '-f'],
])
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698