Reland of Add StyleDifference::needsVisualRectUpdate

Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of https://codereview.chromium.org/2772353002/ )

Abandon the changes about StyleDifference::
m_scrollAnchorDisablingPropertyChanged in the original patch
to avoid performance regressions.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed: https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a096c1813a1bd44
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed: https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13d697c049d3de

TBR=pdr@chromium.org
BUG=704728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2776413002
Cr-Commit-Position: refs/heads/master@{#461214}
Committed: https://chromium.googlesource.com/chromium/src/+/36f76920b08dcd81e97f74afd04474d88f0441e2

[Xianzhu, 2017-03-28 17:47:00]

Created Reland of Add StyleDifference::needsVisualRectUpdate

[Xianzhu, 2017-03-28 17:47:21]

Description was changed from

==========
Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of
https://codereview.chromium.org/2772353002/ )

Reason for revert:
Create a reland for experiment.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of
https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a09...
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13...

TBR=pdr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=704728
==========

to

==========
Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of
https://codereview.chromium.org/2772353002/ )

Reason for revert:
Create a reland for experiment.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of
https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a09...
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13...

BUG=704728
==========

[pdr., 2017-03-28 17:48:00]

On 2017/03/28 at 17:47:00, wangxianzhu wrote:
> Created Reland of Add StyleDifference::needsVisualRectUpdate

Is this just to make the patch or is this out for review?

[Xianzhu, 2017-03-28 17:51:04]

Description was changed from

==========
Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of
https://codereview.chromium.org/2772353002/ )

Reason for revert:
Create a reland for experiment.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of
https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a09...
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13...

BUG=704728
==========

to

==========
Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of
https://codereview.chromium.org/2772353002/ )

Reason for revert:
Create a reland for experiment.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of
https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a09...
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13...

BUG=704728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-03-28 17:51:42]

On 2017/03/28 17:48:00, pdr. wrote:
> On 2017/03/28 at 17:47:00, wangxianzhu wrote:
> > Created Reland of Add StyleDifference::needsVisualRectUpdate
> 
> Is this just to make the patch or is this out for review?

Sorry, not for review yet. Just create a patch for perf tries.

[Xianzhu, 2017-03-30 20:26:52]

This is ready for review. Ptal.

The latest patch contains minimal changes to StyleDifference and ComputedStyle
(with changes about scrollAnchorDisablingPropertyChanged in the original patch
abondaned). It showed no regression.

I guess the regression is related to including
scrollAnchorDisablingPropertyChanged in propertySpecificDifferences in
StyleDifference, but I'm still have no idea how the regression happened.

[Xianzhu, 2017-03-30 20:27:35]

Description was changed from

==========
Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of
https://codereview.chromium.org/2772353002/ )

Reason for revert:
Create a reland for experiment.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of
https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a09...
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13...

BUG=704728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of
https://codereview.chromium.org/2772353002/ )

Abandon the changes about StyleDifference::
m_scrollAnchorDisablingPropertyChanged in the original patch
to avoid performance regressions.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of
https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a09...
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13...

BUG=704728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-03-30 21:54:56]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 21:55:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 23:24:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 23:24:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-03-31 01:02:51]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 01:04:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 02:32:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 02:32:39]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2017-03-31 18:26:52]

TBR because the patch is just a mixture of reland, revert and rebase.

[Xianzhu, 2017-03-31 18:27:10]

Description was changed from

==========
Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of
https://codereview.chromium.org/2772353002/ )

Abandon the changes about StyleDifference::
m_scrollAnchorDisablingPropertyChanged in the original patch
to avoid performance regressions.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of
https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a09...
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13...

BUG=704728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of
https://codereview.chromium.org/2772353002/ )

Abandon the changes about StyleDifference::
m_scrollAnchorDisablingPropertyChanged in the original patch
to avoid performance regressions.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of
https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a09...
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13...

TBR=pdr@chromium.org
BUG=704728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-03-31 18:27:17]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-31 18:27:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 18:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 18:34:39]

CQ experienced an internal error when committing your CL and the maintainers
were notified. Sorry for the inconvenience.

[Xianzhu, 2017-03-31 18:36:41]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-31 18:37:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 18:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 18:43:28]

CQ experienced an internal error when committing your CL and the maintainers
were notified. Sorry for the inconvenience.

[Xianzhu, 2017-03-31 20:36:46]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-03-31 20:37:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 20:43:12]

CQ is committing da patch.

Bot data: {"patchset_id": 270001, "attempt_start_ts": 1490992606238730,
"parent_rev": "d25c21ff39a3dfc462ac0bbbb402f8e314acf576", "commit_rev":
"36f76920b08dcd81e97f74afd04474d88f0441e2"}

[commit-bot: I haz the power, 2017-03-31 20:44:03]

Description was changed from

==========
Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of
https://codereview.chromium.org/2772353002/ )

Abandon the changes about StyleDifference::
m_scrollAnchorDisablingPropertyChanged in the original patch
to avoid performance regressions.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of
https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a09...
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13...

TBR=pdr@chromium.org
BUG=704728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reland of Add StyleDifference::needsVisualRectUpdate (patchset #1 id:1 of
https://codereview.chromium.org/2772353002/ )

Abandon the changes about StyleDifference::
m_scrollAnchorDisablingPropertyChanged in the original patch
to avoid performance regressions.

Original issue's description:
> Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of
https://codereview.chromium.org/2761863002/ )
> 
> Reason for revert:
> BUG=704728
> 
> Original issue's description:
> > Add StyleDifference::needsVisualRectUpdate
> > 
> > It's set when a style change will change visual rect (without changing
> > layout, as visual rect update is implied by layout change).
> > 
> > BTW optimized paint invalidation of box with resizer. We no longer
> > force full paint invalidation for box with resizer when resized.
> > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea
> > if needed.
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > 
> > Review-Url: https://codereview.chromium.org/2761863002
> > Cr-Commit-Position: refs/heads/master@{#458313}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a09...
> 
> TBR=pdr@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> 
> Review-Url: https://codereview.chromium.org/2772353002
> Cr-Commit-Position: refs/heads/master@{#459827}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13...

TBR=pdr@chromium.org
BUG=704728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2776413002
Cr-Commit-Position: refs/heads/master@{#461214}
Committed:
https://chromium.googlesource.com/chromium/src/+/36f76920b08dcd81e97f74afd044...
==========

[commit-bot: I haz the power, 2017-03-31 20:44:05]

Committed patchset #7 (id:270001) as
https://chromium.googlesource.com/chromium/src/+/36f76920b08dcd81e97f74afd044...