Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2772353002: Revert of Add StyleDifference::needsVisualRectUpdate (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add StyleDifference::needsVisualRectUpdate (patchset #5 id:80001 of https://codereview.chromium.org/2761863002/ ) Reason for revert: BUG=704728 Original issue's description: > Add StyleDifference::needsVisualRectUpdate > > It's set when a style change will change visual rect (without changing > layout, as visual rect update is implied by layout change). > > BTW optimized paint invalidation of box with resizer. We no longer > force full paint invalidation for box with resizer when resized. > The resizer will be invlaidated in PaintInvalidationCapableScrollableArea > if needed. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2761863002 > Cr-Commit-Position: refs/heads/master@{#458313} > Committed: https://chromium.googlesource.com/chromium/src/+/4e0d0f9ddd68e59dccda0a8c9a096c1813a1bd44 TBR=pdr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2772353002 Cr-Commit-Position: refs/heads/master@{#459827} Committed: https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13d697c049d3de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -48 lines) Patch
M third_party/WebKit/LayoutTests/paint/invalidation/textarea-appearance-none-resize-handle-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 3 chunks +5 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleDifference.h View 5 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Xianzhu
Created Revert of Add StyleDifference::needsVisualRectUpdate
3 years, 9 months ago (2017-03-27 16:07:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772353002/1
3 years, 9 months ago (2017-03-27 16:08:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bedba279ba5dc64257efc7bc8a13d697c049d3de
3 years, 9 months ago (2017-03-27 18:12:03 UTC) #7
Xianzhu
3 years, 8 months ago (2017-03-28 17:46:59 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2776413002/ by wangxianzhu@chromium.org.

The reason for reverting is: Create a reland for experiment..

Powered by Google App Engine
This is Rietveld 408576698