Reland of Add StyleDifference::needsVisualRectUpdate

third_party/WebKit/Source/core/layout/LayoutObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  *               (http://www.torchmobile.com/)
@@ skipping 1729 matching lines @@
   } else if (diff.needsPaintInvalidationObject() ||
              updatedDiff.needsPaintInvalidationObject()) {
     // TODO(wangxianzhu): For now LayoutSVGRoot::localVisualRect() depends on
     // several styles. Refactor to avoid this special case.
     if (isSVGRoot())
       setShouldDoFullPaintInvalidation();
     else
       setShouldDoFullPaintInvalidationWithoutGeometryChange();
   }
 
+  if (diff.needsVisualRectUpdate())
+    setMayNeedPaintInvalidation();
+
   // Text nodes share style with their parents but the paint properties don't
   // apply to them, hence the !isText() check.
   if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && !isText() &&
       (diff.transformChanged() || diff.opacityChanged() ||
        diff.zIndexChanged() || diff.filterChanged() ||
        diff.backdropFilterChanged() || diff.cssClipChanged())) {
     setNeedsPaintPropertyUpdate();
 
     // We don't need to invalidate paint of objects on SPv2 when only paint
     // property or paint order change. Mark the painting layer needing repaint
     // for changed paint property or paint order. Raster invalidation will be
     // issued if needed during paint.
     if (RuntimeEnabledFeatures::slimmingPaintV2Enabled() &&
         !shouldDoFullPaintInvalidation())
       ObjectPaintInvalidator(*this).slowSetPaintingLayerNeedsRepaint();
   }
 }
 
 void LayoutObject::styleWillChange(StyleDifference diff,
                                    const ComputedStyle& newStyle) {
   if (m_style) {
+    bool visibilityChanged = m_style->visibility() != newStyle.visibility();
     // If our z-index changes value or our visibility changes,
     // we need to dirty our stacking context's z-order list.
-    bool visibilityChanged =
-        m_style->visibility() != newStyle.visibility() ||
-        m_style->zIndex() != newStyle.zIndex() ||
-        m_style->isStackingContext() != newStyle.isStackingContext();
-    if (visibilityChanged) {
+    if (visibilityChanged || m_style->zIndex() != newStyle.zIndex() ||
+        m_style->isStackingContext() != newStyle.isStackingContext()) {
       document().setAnnotatedRegionsDirty(true);
       if (AXObjectCache* cache = document().existingAXObjectCache())
         cache->childrenChanged(parent());
     }
 
     // Keep layer hierarchy visibility bits up to date if visibility changes.
-    if (m_style->visibility() != newStyle.visibility()) {
+    if (visibilityChanged) {
       // We might not have an enclosing layer yet because we might not be in the
       // tree.
       if (PaintLayer* layer = enclosingLayer())
         layer->dirtyVisibleContentStatus();
     }
 
     if (isFloating() && (m_style->floating() != newStyle.floating())) {
       // For changes in float styles, we need to conceivably remove ourselves
       // from the floating objects list.
       toLayoutBox(this)->removeFloatingOrPositionedChildFromBlockLists();
@@ skipping 1831 matching lines @@
     const blink::LayoutObject* root = object1;
     while (root->parent())
       root = root->parent();
     root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
   } else {
     WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
   }
 }
 
 #endif