Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2776043002: Revert of DevTools: fix mixed arguments in Tracing.bufferUsage event (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: fix mixed arguments in Tracing.bufferUsage event (patchset #1 id:1 of https://codereview.chromium.org/2752083002/ ) Reason for revert: Speculative, looks like this broke a bunch of devtool tests on msan, first failure at https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6404 but still broken 80 builds later. Original issue's description: > DevTools: fix mixed arguments in Tracing.bufferUsage event > > Originally regressed by https://codereview.chromium.org/2500093002 > > BUG=b/36176396 > > Review-Url: https://codereview.chromium.org/2752083002 > Cr-Commit-Position: refs/heads/master@{#457227} > Committed: https://chromium.googlesource.com/chromium/src/+/c8dc5d159a4716659d8698b093794f7c9eaa24ed TBR=dgozman@chromium.org,caseq@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=b/36176396 Review-Url: https://codereview.chromium.org/2776043002 Cr-Commit-Position: refs/heads/master@{#459668} Committed: https://chromium.googlesource.com/chromium/src/+/e14291f0adaf71cd42ef1c1a9d70ace4e309a1ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/devtools/protocol/tracing_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
Created Revert of DevTools: fix mixed arguments in Tracing.bufferUsage event
3 years, 9 months ago (2017-03-26 01:31:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776043002/1
3 years, 9 months ago (2017-03-26 01:31:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e14291f0adaf71cd42ef1c1a9d70ace4e309a1ba
3 years, 9 months ago (2017-03-26 03:12:47 UTC) #6
caseq
3 years, 9 months ago (2017-03-26 23:08:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2763413011/ by caseq@chromium.org.

The reason for reverting is: Re-land, see comments in
https://codereview.chromium.org/2752083002 for details.
BUG=705306.

Powered by Google App Engine
This is Rietveld 408576698