Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2752083002: DevTools: fix mixed arguments in Tracing.bufferUsage event (Closed)

Created:
3 years, 9 months ago by caseq
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix mixed arguments in Tracing.bufferUsage event Originally regressed by https://codereview.chromium.org/2500093002 BUG=b/36176396 Review-Url: https://codereview.chromium.org/2752083002 Cr-Commit-Position: refs/heads/master@{#457227} Committed: https://chromium.googlesource.com/chromium/src/+/c8dc5d159a4716659d8698b093794f7c9eaa24ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/devtools/protocol/tracing_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
caseq
3 years, 9 months ago (2017-03-15 19:38:01 UTC) #2
dgozman
lgtm Why all the tests pass?
3 years, 9 months ago (2017-03-15 20:50:55 UTC) #3
caseq
On 2017/03/15 20:50:55, dgozman wrote: > > Why all the tests pass? Well, these are ...
3 years, 9 months ago (2017-03-15 20:53:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752083002/1
3 years, 9 months ago (2017-03-15 20:54:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c8dc5d159a4716659d8698b093794f7c9eaa24ed
3 years, 9 months ago (2017-03-15 22:06:25 UTC) #9
Nico
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2776043002/ by thakis@chromium.org. ...
3 years, 9 months ago (2017-03-26 01:31:08 UTC) #10
caseq
3 years, 9 months ago (2017-03-26 23:06:55 UTC) #11
Message was sent while issue was closed.
On 2017/03/26 01:31:08, Nico wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2776043002/ by mailto:thakis@chromium.org.
> 
> The reason for reverting is: Speculative, looks like this broke a bunch of
> devtool tests on msan, first failure at
>
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...
> but still broken 80 builds later..

I'm sure this isn't the cause - these tests don't even use tracing, and the
stacks don't seem to have anything to do with the change. I would suspect
https://chromium.googlesource.com/chromium/src/+/2d7d2c3632187e2cfaaa5c6ec26d...
based on the stacks.

Powered by Google App Engine
This is Rietveld 408576698