[DevTools] Move IO and Tracing to new generator.

[DevTools] Move IO and Tracing to new generator.

This also includes roll of inspector_protocol which supports new required features:
73028acaa3646789fd2a3bfd0d79eb2d91b696b3: [inspector_protocol] Support features for content/ generator.

BUG=664683
Committed: https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861
Cr-Commit-Position: refs/heads/master@{#433389}

[dgozman, 2016-11-15 01:47:55]

Description was changed from

==========
io and tracing to new generator

BUG=
==========

to

==========
[DevTools] Move IO and Tracing to new generator.

This also adds support for all tracing quirks:
- sendRawMessage;
- fallThrough from async methods;
- sending double values;
- toBaseValue(protocol::Value).

BUG=664683
==========

[dgozman, 2016-11-15 01:48:31]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2016-11-15 01:48:31]

Could you please take a look?

[caseq, 2016-11-15 18:33:59]

lgtm % comments

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_protocol_handler.cc (right):

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_protocol_handler.cc:73: return
HandleOptionalCommand(session_id, std::move(command), call_id, method);
nit: you can now extract method right here.

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/io_handler.cc (right):

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/io_handler.cc:47:
callback->sendFailure(Response::Error("Invalid stream handle"));
let's keep different error codes -- just make a method for each different error,
and keep the error text for humans.

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/tracing_handler.cc (right):

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/tracing_handler.cc:186:
callback->sendFailure(Response::Error(
InvalidParams

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/tracing_handler.cc:207:
categories.fromMaybe(std::string()),
""

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/tracing_handler.cc:208:
options.fromMaybe(std::string()));
""

[dgozman, 2016-11-17 21:51:07]

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/io_handler.cc (right):

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/io_handler.cc:47:
callback->sendFailure(Response::Error("Invalid stream handle"));
On 2016/11/15 18:33:59, caseq wrote:
> let's keep different error codes -- just make a method for each different
error,
> and keep the error text for humans.

Done.

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/tracing_handler.cc (right):

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/tracing_handler.cc:186:
callback->sendFailure(Response::Error(
On 2016/11/15 18:33:59, caseq wrote:
> InvalidParams

Done.

https://codereview.chromium.org/2500093002/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/tracing_handler.cc:207:
categories.fromMaybe(std::string()),
On 2016/11/15 18:33:59, caseq wrote:
> ""

Done.

[dgozman, 2016-11-17 21:55:59]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 21:57:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 22:22:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:22:19]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dgozman, 2016-11-18 19:44:21]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 19:45:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 22:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 22:14:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-11-18 23:27:50]

Description was changed from

==========
[DevTools] Move IO and Tracing to new generator.

This also adds support for all tracing quirks:
- sendRawMessage;
- fallThrough from async methods;
- sending double values;
- toBaseValue(protocol::Value).

BUG=664683
==========

to

==========
[DevTools] Move IO and Tracing to new generator.

This also includes roll of inspector_protocol which supports new required
features:
73028acaa3646789fd2a3bfd0d79eb2d91b696b3: [inspector_protocol] Support features
for content/ generator.

BUG=664683
==========

[dgozman, 2016-11-18 23:28:19]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-11-18 23:28:19]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2500093002/#ps100001
(title: "roll")

[commit-bot: I haz the power, 2016-11-18 23:29:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 03:28:43]

Description was changed from

==========
[DevTools] Move IO and Tracing to new generator.

This also includes roll of inspector_protocol which supports new required
features:
73028acaa3646789fd2a3bfd0d79eb2d91b696b3: [inspector_protocol] Support features
for content/ generator.

BUG=664683
==========

to

==========
[DevTools] Move IO and Tracing to new generator.

This also includes roll of inspector_protocol which supports new required
features:
73028acaa3646789fd2a3bfd0d79eb2d91b696b3: [inspector_protocol] Support features
for content/ generator.

BUG=664683
==========

[commit-bot: I haz the power, 2016-11-19 03:28:44]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-19 03:30:33]

Description was changed from

==========
[DevTools] Move IO and Tracing to new generator.

This also includes roll of inspector_protocol which supports new required
features:
73028acaa3646789fd2a3bfd0d79eb2d91b696b3: [inspector_protocol] Support features
for content/ generator.

BUG=664683
==========

to

==========
[DevTools] Move IO and Tracing to new generator.

This also includes roll of inspector_protocol which supports new required
features:
73028acaa3646789fd2a3bfd0d79eb2d91b696b3: [inspector_protocol] Support features
for content/ generator.

BUG=664683

Committed: https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861
Cr-Commit-Position: refs/heads/master@{#433389}
==========

[commit-bot: I haz the power, 2016-11-19 03:30:34]

Patchset 6 (id:??) landed as
https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861
Cr-Commit-Position: refs/heads/master@{#433389}