Compile more targets in foreground/js/ui in gyp v2 (3)

Compile more targets in foreground/js/ui in gyp v2 (3)

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2773873003
Cr-Commit-Position: refs/heads/master@{#459717}
Committed: https://chromium.googlesource.com/chromium/src/+/00dda6dbc09aa8a14805cbba3d78b5b1569620ca

[oka, 2017-03-24 05:04:14]

Description was changed from

==========
Compile more targets in foreground/js/ui in gyp v2 (3)

BUG=636289
TEST=run_compiler
==========

to

==========
Compile more targets in foreground/js/ui in gyp v2 (3)

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-03-24 05:05:13]

.

[oka, 2017-03-24 05:05:46]

.

[oka, 2017-03-24 05:06:29]

oka@chromium.org changed reviewers:
+ dbeam@chromium.org, fukino@chromium.org

[oka, 2017-03-24 05:06:30]

PTAL.

dbeam@ for ui/webui/resources/js/cr/ui/compiled_resources2.gyp
fukino@ for others.

[fukino, 2017-03-24 05:24:02]

https://codereview.chromium.org/2773873003/diff/40001/ui/file_manager/externs...
File ui/file_manager/externs/list.js (right):

https://codereview.chromium.org/2773873003/diff/40001/ui/file_manager/externs...
ui/file_manager/externs/list.js:15: * TODO(oka): Remove this workaround.
How about defining a interface such as DragTarget and "@implements {DragTarget}"
in FileTableList and FileGrid?

[oka, 2017-03-24 08:35:00]

PTAL.

https://codereview.chromium.org/2773873003/diff/40001/ui/file_manager/externs...
File ui/file_manager/externs/list.js (right):

https://codereview.chromium.org/2773873003/diff/40001/ui/file_manager/externs...
ui/file_manager/externs/list.js:15: * TODO(oka): Remove this workaround.
On 2017/03/24 05:24:02, fukino wrote:
> How about defining a interface such as DragTarget and "@implements
{DragTarget}"
> in FileTableList and FileGrid?

Done. Defined DragTarget and made drag_selector depends on it.

[fukino, 2017-03-24 08:40:10]

https://codereview.chromium.org/2773873003/diff/60001/ui/file_manager/externs...
File ui/file_manager/externs/drag_target.js (right):

https://codereview.chromium.org/2773873003/diff/60001/ui/file_manager/externs...
ui/file_manager/externs/drag_target.js:6: * @constructor
@interface

https://codereview.chromium.org/2773873003/diff/60001/ui/file_manager/externs...
ui/file_manager/externs/drag_target.js:7: * @extends {cr.ui.List}
This interface does not have to extend cr.ui.List.
How about: FileTableList and FileGrid extend cr.ui.List and implements
DragTarget.

[Dan Beam, 2017-03-25 06:51:44]

lgtm

[oka, 2017-03-27 02:19:01]

.

[oka, 2017-03-27 02:21:18]

PTAL.

https://codereview.chromium.org/2773873003/diff/60001/ui/file_manager/externs...
File ui/file_manager/externs/drag_target.js (right):

https://codereview.chromium.org/2773873003/diff/60001/ui/file_manager/externs...
ui/file_manager/externs/drag_target.js:6: * @constructor
On 2017/03/24 08:40:10, fukino wrote:
> @interface

Done.

https://codereview.chromium.org/2773873003/diff/60001/ui/file_manager/externs...
ui/file_manager/externs/drag_target.js:6: * @constructor
On 2017/03/24 08:40:10, fukino wrote:
> @interface

Done.

https://codereview.chromium.org/2773873003/diff/60001/ui/file_manager/externs...
ui/file_manager/externs/drag_target.js:7: * @extends {cr.ui.List}
On 2017/03/24 08:40:10, fukino wrote:
> This interface does not have to extend cr.ui.List.
> How about: FileTableList and FileGrid extend cr.ui.List and implements
> DragTarget.

Removed @extends, and added type cast to callers of getHitElements.

Actually FileTableList is not the type of the variable what having
getHitElements, but cr.ui.List is. file_table.js adds the method to cr.ui.List.
So adding @implements would not be feasible.

[fukino, 2017-03-27 04:41:22]

lgtm

[oka, 2017-03-27 07:09:30]

The CQ bit was checked by oka@chromium.org

[oka, 2017-03-27 07:09:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2773873003/#ps80001
(title: ".")

[commit-bot: I haz the power, 2017-03-27 07:09:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 08:01:21]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490598570569420,
"parent_rev": "76a24849ff7e58c331cfdf9fcac20db78d661669", "commit_rev":
"00dda6dbc09aa8a14805cbba3d78b5b1569620ca"}

[commit-bot: I haz the power, 2017-03-27 08:02:54]

Description was changed from

==========
Compile more targets in foreground/js/ui in gyp v2 (3)

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile more targets in foreground/js/ui in gyp v2 (3)

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2773873003
Cr-Commit-Position: refs/heads/master@{#459717}
Committed:
https://chromium.googlesource.com/chromium/src/+/00dda6dbc09aa8a14805cbba3d78...
==========

[commit-bot: I haz the power, 2017-03-27 08:02:59]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/00dda6dbc09aa8a14805cbba3d78...

[kolos1, 2017-03-27 09:23:11]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2772223002/ by kolos@chromium.org.

The reason for reverting is: It probably caused closing tree. .