Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2775573002: Generate keyword part of vertical-align property in ComputedStyleBase. (Closed)

Created:
3 years, 9 months ago by shend
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate keyword part of vertical-align property in ComputedStyleBase. The vertical-align property can either have a keyword value or a length value. The two values are stored separately in ComputedStyle. The keyword part is stored directly in ComputedStyle, but the length part is stored in StyleBoxData. Hence, generating this property is quite difficult. This patch generates just the keyword part of vertical-align. To make it clear that this is not generating the whole of vertical-align properly, we generate it as a 'storage_only' nonproperty. Diff of generated files: https://gist.github.com/3e52ce1e0e38fd208196ed0621f6c0b3/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2775573002 Cr-Commit-Position: refs/heads/master@{#460283} Committed: https://chromium.googlesource.com/chromium/src/+/18d53b4dbb62b07ff63391b11519ab4b8332a93b

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 3 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 3 chunks +8 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
shend
Hi Alan, PTAL
3 years, 9 months ago (2017-03-23 22:43:33 UTC) #3
alancutter (OOO until 2018)
lgtm
3 years, 8 months ago (2017-03-28 23:47:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775573002/20001
3 years, 8 months ago (2017-03-29 03:20:44 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 05:15:29 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/18d53b4dbb62b07ff63391b11519...

Powered by Google App Engine
This is Rietveld 408576698