Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2775573002: Generate keyword part of vertical-align property in ComputedStyleBase. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 763b26413dbedcbd6bbd51a0ae8a7cc88a1b903e..acc7d85c45281f340b8dca28b3b355713890c17c 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -347,7 +347,8 @@ void ComputedStyle::copyNonInheritedFromCached(const ComputedStyle& other) {
// See comments for each skipped flag below.
setOriginalDisplay(
other.originalDisplay()); // Not generated in ComputedStyleBase.
- m_nonInheritedData.m_verticalAlign = other.m_nonInheritedData.m_verticalAlign;
+ setVerticalAlign(
+ other.verticalAlign()); // Not generated in ComputedStyleBase
m_nonInheritedData.m_hasViewportUnits =
other.m_nonInheritedData.m_hasViewportUnits;
m_nonInheritedData.m_hasRemUnits = other.m_nonInheritedData.m_hasRemUnits;
@@ -483,9 +484,11 @@ bool ComputedStyle::nonInheritedEqual(const ComputedStyle& other) const {
return ComputedStyleBase::nonInheritedEqual(other) &&
originalDisplay() ==
other.originalDisplay() && // Not generated in ComputedStyleBase
- m_nonInheritedData == other.m_nonInheritedData &&
- m_box == other.m_box && m_visual == other.m_visual &&
- m_background == other.m_background && m_surround == other.m_surround &&
+ verticalAlign() ==
+ other.verticalAlign() && // Not generated in ComputedStyleBase
+ m_box == other.m_box &&
+ m_visual == other.m_visual && m_background == other.m_background &&
+ m_surround == other.m_surround &&
m_rareNonInheritedData == other.m_rareNonInheritedData &&
m_svgStyle->nonInheritedEqual(*other.m_svgStyle);
}
@@ -856,8 +859,7 @@ bool ComputedStyle::diffNeedsFullLayout(const ComputedStyle& other) const {
return true;
}
- if (m_nonInheritedData.m_verticalAlign !=
- other.m_nonInheritedData.m_verticalAlign ||
+ if (verticalAlign() != other.verticalAlign() ||
position() != other.position())
return true;
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698