Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2766973002: Generate nonproperty originalDisplay in ComputedStyleBase. (Closed)

Created:
3 years, 9 months ago by shend
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate nonproperty originalDisplay in ComputedStyleBase. The nonproperty originalDisplay has the same behaviour as effectiveDisplay. It is used to save the value of effectiveDisplay before we mutate ComputedStyle. This patch moves this field to be generated in ComputedStyleBase. Diff of generated files: https://gist.github.com/darrnshn/fbb2854779c4c6e232036b86bed581e4/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2766973002 Cr-Commit-Position: refs/heads/master@{#460220} Committed: https://chromium.googlesource.com/chromium/src/+/564f08807c0a1721eabe2a76f20d42020d94cf48

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 4 chunks +2 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 3 chunks +5 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
shend
Hi Renee, PTAL for a first pass review :) Let me know if you need ...
3 years, 9 months ago (2017-03-22 04:37:04 UTC) #2
rjwright
On 2017/03/22 04:37:04, shend wrote: > Hi Renee, PTAL for a first pass review :) ...
3 years, 9 months ago (2017-03-23 03:36:10 UTC) #3
shend
Hi Alan, PTAL :)
3 years, 9 months ago (2017-03-23 22:44:12 UTC) #5
alancutter (OOO until 2018)
lgtm
3 years, 9 months ago (2017-03-28 02:03:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2766973002/20001
3 years, 8 months ago (2017-03-28 21:50:42 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 22:11:55 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/564f08807c0a1721eabe2a76f20d...

Powered by Google App Engine
This is Rietveld 408576698