Add an options page to Select-to-Speak and allow setting voice name, rate

Add an options page to Select-to-Speak and allow setting voice name, rate

BUG=676449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2782993002
Cr-Commit-Position: refs/heads/master@{#461300}
Committed: https://chromium.googlesource.com/chromium/src/+/2930543f608f9ed9ca27bc0a1f1a8ab80ed054ac

[dmazzoni, 2017-03-29 20:40:13]

Description was changed from

==========
Add an options page to Select-to-Speak and allow setting voice name, rate

BUG=676449
==========

to

==========
Add an options page to Select-to-Speak and allow setting voice name, rate

BUG=676449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2017-03-29 20:40:28]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org, elichtenberg@google.com

[David Tseng, 2017-03-29 22:24:46]

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/select_to_speak/options.html (right):

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/select_to_speak/options.html:35: <option
value="2.0">200%</option>
Would be nice to make these human friendly (e.g. very slow, slow, ...)

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
(right):

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js:233: if
(prefs['voice']) {
Just a warning, a voice synced in this way might be invalid on this machine. For
example, if I use a Chromebook with ARC, and select that voice. Logging into
another Chromebook without that voice will sync 'android' for the voice, but
nothing on this machine will speak.

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/select_to_speak/select_to_speak_options.js
(right):

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/select_to_speak/select_to_speak_options.js:20:
window.speechSynthesis.onvoiceschanged = (function() {
No need for outer closure here.

[dmazzoni, 2017-03-30 20:19:17]

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/select_to_speak/options.html (right):

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/select_to_speak/options.html:35: <option
value="2.0">200%</option>
On 2017/03/29 22:24:45, David Tseng wrote:
> Would be nice to make these human friendly (e.g. very slow, slow, ...)

Done.

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
(right):

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js:233: if
(prefs['voice']) {
On 2017/03/29 22:24:46, David Tseng wrote:
> Just a warning, a voice synced in this way might be invalid on this machine.
For
> example, if I use a Chromebook with ARC, and select that voice. Logging into
> another Chromebook without that voice will sync 'android' for the voice, but
> nothing on this machine will speak.

Good catch.

I made this more robust by tracking the prefs voice,
the best voice for the locale, and the installed 
voices, all separately. Now it takes all of that
into account each time it sends a speech command.

I tested it manually by setting the pref to an
extension voice, then uninstalling the extension and
verifying that it falls back on the best voice for
the locale.

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/select_to_speak/select_to_speak_options.js
(right):

https://codereview.chromium.org/2782993002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/select_to_speak/select_to_speak_options.js:20:
window.speechSynthesis.onvoiceschanged = (function() {
On 2017/03/29 22:24:46, David Tseng wrote:
> No need for outer closure here.

Done.

[David Tseng, 2017-03-31 20:21:34]

lgtm

[dmazzoni, 2017-03-31 21:14:54]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-03-31 21:15:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 22:33:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 22:33:48]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-04-01 00:16:55]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-04-01 00:16:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2782993002/#ps40001
(title: "fix unit tests")

[commit-bot: I haz the power, 2017-04-01 00:17:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-01 01:32:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491005815517390,
"parent_rev": "553df4cf074e9bb28abb303794af949730c6c77f", "commit_rev":
"2930543f608f9ed9ca27bc0a1f1a8ab80ed054ac"}

[commit-bot: I haz the power, 2017-04-01 01:36:05]

Description was changed from

==========
Add an options page to Select-to-Speak and allow setting voice name, rate

BUG=676449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add an options page to Select-to-Speak and allow setting voice name, rate

BUG=676449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2782993002
Cr-Commit-Position: refs/heads/master@{#461300}
Committed:
https://chromium.googlesource.com/chromium/src/+/2930543f608f9ed9ca27bc0a1f1a...
==========

[commit-bot: I haz the power, 2017-04-01 01:36:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2930543f608f9ed9ca27bc0a1f1a...