Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2775193003: Reland of Compile more targets in foreground/js/ui in gyp v2 (3) (Closed)

Created:
3 years, 9 months ago by oka
Modified:
3 years, 9 months ago
Reviewers:
kolos1, Dan Beam, fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Compile more targets in foreground/js/ui in gyp v2 (3) (patchset #1 id:1 of https://codereview.chromium.org/2772223002/ ) Reason for revert: Revert was do to Android breakage, but I believe my CL is not to do with Android. Let me reland. Original issue's description: > Revert of Compile more targets in foreground/js/ui in gyp v2 (3) (patchset #5 id:80001 of https://codereview.chromium.org/2773873003/ ) > > Reason for revert: > It probably caused closing tree. > > Original issue's description: > > Compile more targets in foreground/js/ui in gyp v2 (3) > > > > BUG=636289 > > TEST=run_compiler > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > > > Review-Url: https://codereview.chromium.org/2773873003 > > Cr-Commit-Position: refs/heads/master@{#459717} > > Committed: https://chromium.googlesource.com/chromium/src/+/00dda6dbc09aa8a14805cbba3d78b5b1569620ca > > TBR=dbeam@chromium.org,fukino@chromium.org,oka@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=636289 > > Review-Url: https://codereview.chromium.org/2772223002 > Cr-Commit-Position: refs/heads/master@{#459729} > Committed: https://chromium.googlesource.com/chromium/src/+/154c7e0df334aae1e1e78b808da5d49cfcf5ed4c TBR=dbeam@chromium.org,fukino@chromium.org,kolos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636289 Review-Url: https://codereview.chromium.org/2775193003 Cr-Commit-Position: refs/heads/master@{#459768} Committed: https://chromium.googlesource.com/chromium/src/+/a3f99551f1cbc6cd881574f55d03577f5c9adc09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -18 lines) Patch
M ui/file_manager/externs/compiled_resources2.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
A ui/file_manager/externs/drag_target.js View 1 chunk +20 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 3 chunks +25 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/drag_selector.js View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/webui/resources/js/cr/ui/compiled_resources2.gyp View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
oka
Created Reland of Compile more targets in foreground/js/ui in gyp v2 (3)
3 years, 9 months ago (2017-03-27 13:13:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775193003/1
3 years, 9 months ago (2017-03-27 13:13:24 UTC) #3
oka
PTAL.
3 years, 9 months ago (2017-03-27 13:13:44 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 13:15:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3f99551f1cbc6cd881574f55d03...

Powered by Google App Engine
This is Rietveld 408576698