Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Issue 2772223002: Revert of Compile more targets in foreground/js/ui in gyp v2 (3) (Closed)

Created:
3 years, 8 months ago by kolos1
Modified:
3 years, 8 months ago
Reviewers:
oka, Dan Beam, fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Compile more targets in foreground/js/ui in gyp v2 (3) (patchset #5 id:80001 of https://codereview.chromium.org/2773873003/ ) Reason for revert: It probably caused closing tree. Original issue's description: > Compile more targets in foreground/js/ui in gyp v2 (3) > > BUG=636289 > TEST=run_compiler > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2773873003 > Cr-Commit-Position: refs/heads/master@{#459717} > Committed: https://chromium.googlesource.com/chromium/src/+/00dda6dbc09aa8a14805cbba3d78b5b1569620ca TBR=dbeam@chromium.org,fukino@chromium.org,oka@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636289 Review-Url: https://codereview.chromium.org/2772223002 Cr-Commit-Position: refs/heads/master@{#459729} Committed: https://chromium.googlesource.com/chromium/src/+/154c7e0df334aae1e1e78b808da5d49cfcf5ed4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -89 lines) Patch
M ui/file_manager/externs/compiled_resources2.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/file_manager/externs/drag_target.js View 1 chunk +0 lines, -20 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 3 chunks +12 lines, -25 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/drag_selector.js View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/webui/resources/js/cr/ui/compiled_resources2.gyp View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kolos1
Created Revert of Compile more targets in foreground/js/ui in gyp v2 (3)
3 years, 8 months ago (2017-03-27 09:23:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772223002/1
3 years, 8 months ago (2017-03-27 09:23:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/154c7e0df334aae1e1e78b808da5d49cfcf5ed4c
3 years, 8 months ago (2017-03-27 09:24:58 UTC) #6
oka
3 years, 8 months ago (2017-03-27 13:13:11 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2775193003/ by oka@chromium.org.

The reason for reverting is: Revert was do to Android breakage, but I believe my
CL is not to do with Android. Let me reland..

Powered by Google App Engine
This is Rietveld 408576698