Assign names to VR UI elements for debugging and test.

Assign names to VR UI elements for debugging and test.

This is a first cut of naming UI elements. Names can be used to debug
native rendering issues, or in the future, for looking up elements by
name.  The names currently assigned are arbitrary, and may be changed as
desired in the future.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2775003002
Cr-Commit-Position: refs/heads/master@{#459896}
Committed: https://chromium.googlesource.com/chromium/src/+/bf6fed8ee477361932688fd9a5eb75039848e294

[cjgrant, 2017-03-24 21:48:34]

Description was changed from

==========
Assign names to VR UI elements for debugging and test.

This is a first cut of naming UI elements. Names can be used to debug
native rendering issues, or in the future, for looking up elements by
name.  The names currently assigned are arbitrary, and may be changed as
desired in the future.

BUG=None
==========

to

==========
Assign names to VR UI elements for debugging and test.

This is a first cut of naming UI elements. Names can be used to debug
native rendering issues, or in the future, for looking up elements by
name.  The names currently assigned are arbitrary, and may be changed as
desired in the future.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[cjgrant, 2017-03-24 21:48:53]

cjgrant@chromium.org changed reviewers:
+ bsheedy@chromium.org, tiborg@chromium.org

[bsheedy, 2017-03-24 21:54:30]

LGTM, I'll update my Java > Native patch to use names once this lands.

[tiborg, 2017-03-24 22:03:06]

https://codereview.chromium.org/2775003002/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2775003002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:744: let groundPlane = new
api.UiElement();
Why make these UiElements? They don't show a sprite.

[cjgrant, 2017-03-27 14:03:22]

https://codereview.chromium.org/2775003002/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2775003002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:744: let groundPlane = new
api.UiElement();
On 2017/03/24 22:03:06, tiborg wrote:
> Why make these UiElements? They don't show a sprite.

UiElement is meant to be passed to ui.addElement(), and UiElementUpdate for
ui.updateElement().  However, I see my change fails on closure, as creating a
UiElement does require 4 arguments.  It feels like UiElement should be
subclassed to UiSpriteElement.  Thoughts?

[tiborg, 2017-03-27 14:55:07]

https://codereview.chromium.org/2775003002/diff/1/chrome/browser/resources/vr...
File chrome/browser/resources/vr_shell/vr_shell_ui.js (right):

https://codereview.chromium.org/2775003002/diff/1/chrome/browser/resources/vr...
chrome/browser/resources/vr_shell/vr_shell_ui.js:744: let groundPlane = new
api.UiElement();
On 2017/03/27 14:03:22, cjgrant wrote:
> On 2017/03/24 22:03:06, tiborg wrote:
> > Why make these UiElements? They don't show a sprite.
> 
> UiElement is meant to be passed to ui.addElement(), and UiElementUpdate for
> ui.updateElement().  However, I see my change fails on closure, as creating a
> UiElement does require 4 arguments.  It feels like UiElement should be
> subclassed to UiSpriteElement.  Thoughts?

As discussed offline, let's move this change to a future CL.

[cjgrant, 2017-03-27 15:22:00]

cjgrant@chromium.org changed reviewers:
+ mthiesse@chromium.org

[tiborg, 2017-03-27 15:31:31]

On 2017/03/27 15:22:01, cjgrant wrote:

lgtm

[mthiesse, 2017-03-27 15:32:27]

lgtm

[cjgrant, 2017-03-27 19:08:32]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2017-03-27 19:08:33]

The patchset sent to the CQ was uploaded after l-g-t-m from bsheedy@chromium.org
Link to the patchset: https://codereview.chromium.org/2775003002/#ps20001
(title: "Restore use of UiElementUpdate when adding non-sprite UI elements.")

[commit-bot: I haz the power, 2017-03-27 19:09:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 20:05:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 20:05:33]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cjgrant, 2017-03-27 20:14:02]

The CQ bit was checked by cjgrant@chromium.org

[commit-bot: I haz the power, 2017-03-27 20:14:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 21:59:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490645642087380,
"parent_rev": "d83b035e1cb466ff77c52973fe633fe780833325", "commit_rev":
"bf6fed8ee477361932688fd9a5eb75039848e294"}

[commit-bot: I haz the power, 2017-03-27 22:00:25]

Description was changed from

==========
Assign names to VR UI elements for debugging and test.

This is a first cut of naming UI elements. Names can be used to debug
native rendering issues, or in the future, for looking up elements by
name.  The names currently assigned are arbitrary, and may be changed as
desired in the future.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Assign names to VR UI elements for debugging and test.

This is a first cut of naming UI elements. Names can be used to debug
native rendering issues, or in the future, for looking up elements by
name.  The names currently assigned are arbitrary, and may be changed as
desired in the future.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2775003002
Cr-Commit-Position: refs/heads/master@{#459896}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf6fed8ee477361932688fd9a5eb...
==========

[commit-bot: I haz the power, 2017-03-27 22:00:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bf6fed8ee477361932688fd9a5eb...