chrome/browser/android/vr_shell/ui_scene_unittest.cc - Issue 2775003002: Assign names to VR UI elements for debugging and test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/ui_scene_unittest.cc

Issue 2775003002: Assign names to VR UI elements for debugging and test. (Closed)

Patch Set: Restore use of UiElementUpdate when adding non-sprite UI elements. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/ui_scene_unittest.cc

diff --git a/chrome/browser/android/vr_shell/ui_scene_unittest.cc b/chrome/browser/android/vr_shell/ui_scene_unittest.cc

index a538189806f07ea3550242f6b385602ca9d866a4..cfcc3d6ef9a4b708ded496bd5ebc3f302e18ac0b 100644

--- a/chrome/browser/android/vr_shell/ui_scene_unittest.cc

+++ b/chrome/browser/android/vr_shell/ui_scene_unittest.cc

@@ -225,6 +225,7 @@ TEST(UiScene, AddUiElementFromDictionary) {

base::DictionaryValue dict;

dict.SetInteger("id", 10);

+ dict.SetString("name", "abc");

dict.SetInteger("parentId", 11);

dict.SetBoolean("visible", false);

dict.SetBoolean("hitTestable", false);

@@ -259,6 +260,7 @@ TEST(UiScene, AddUiElementFromDictionary) {

EXPECT_NE(element, nullptr);

EXPECT_EQ(element->id, 10);

+ EXPECT_EQ(element->name, "abc");

EXPECT_EQ(element->parent_id, 11);

EXPECT_EQ(element->visible, false);

EXPECT_EQ(element->hit_testable, false);