Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 2774753004: Add SVGFitToViewBox::hasValidViewBox helper (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SVGFitToViewBox::hasValidViewBox helper This encapsulates the use of the 'is valid' flag of SVGRect. This both makes for more readable code, and should make it easier to transition away from the 'is valid' flag. (Note: !isSpecified() implies !isValid().) BUG=703050 Review-Url: https://codereview.chromium.org/2774753004 Cr-Commit-Position: refs/heads/master@{#459520} Committed: https://chromium.googlesource.com/chromium/src/+/b7bd3497dd98baebe652fa5840d8b54cd466a024

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M third_party/WebKit/Source/core/svg/SVGFitToViewBox.h View 3 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPatternElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewSpec.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 9 months ago (2017-03-24 15:08:18 UTC) #5
pdr.
On 2017/03/24 at 15:08:18, fs wrote: > LGTM
3 years, 9 months ago (2017-03-24 16:30:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774753004/1
3 years, 9 months ago (2017-03-24 19:22:35 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 19:30:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7bd3497dd98baebe652fa5840d8...

Powered by Google App Engine
This is Rietveld 408576698