third_party/WebKit/Source/core/svg/SVGViewSpec.h - Issue 2774753004: Add SVGFitToViewBox::hasValidViewBox helper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGViewSpec.h

Issue 2774753004: Add SVGFitToViewBox::hasValidViewBox helper (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGViewSpec.h

diff --git a/third_party/WebKit/Source/core/svg/SVGViewSpec.h b/third_party/WebKit/Source/core/svg/SVGViewSpec.h

index ac8fe5c3722b0006c1c7a3d2c9d28f6d946d1434..56ec82643134fb7224fa7ea404e633ebb6cf7103 100644

--- a/third_party/WebKit/Source/core/svg/SVGViewSpec.h

+++ b/third_party/WebKit/Source/core/svg/SVGViewSpec.h

@@ -65,7 +65,7 @@ class SVGViewSpec final : public GarbageCollectedFinalized<SVGViewSpec>,

template <typename T>

void SVGViewSpec::inheritViewAttributesFromElement(T& inheritFromElement) {

- if (inheritFromElement.viewBox()->currentValue()->isValid())

+ if (inheritFromElement.hasValidViewBox())

setViewBox(inheritFromElement.viewBox()->currentValue()->value());

if (inheritFromElement.preserveAspectRatio()->isSpecified()) {

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGSVGElement.cpp ('k') | no next file » | no next file with comments »