third_party/WebKit/Source/core/svg/SVGPatternElement.cpp - Issue 2774753004: Add SVGFitToViewBox::hasValidViewBox helper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGPatternElement.cpp

Issue 2774753004: Add SVGFitToViewBox::hasValidViewBox helper (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGPatternElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGPatternElement.cpp b/third_party/WebKit/Source/core/svg/SVGPatternElement.cpp

index c95abef1808ca0b4bdc542036e951430663343ea..087de52c808cfabb39218658c1ba1f042deb6571 100644

--- a/third_party/WebKit/Source/core/svg/SVGPatternElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGPatternElement.cpp

@@ -162,8 +162,7 @@ static void setPatternAttributes(const SVGPatternElement* element,

if (!attributes.hasHeight() && element->height()->isSpecified())

attributes.setHeight(element->height()->currentValue());

- if (!attributes.hasViewBox() && element->viewBox()->isSpecified() &&

- element->viewBox()->currentValue()->isValid())

+ if (!attributes.hasViewBox() && element->hasValidViewBox())

attributes.setViewBox(element->viewBox()->currentValue()->value());

if (!attributes.hasPreserveAspectRatio() &&