Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2774603002: Removes the IsReadingListEnabled flags (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
Olivier, sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes the IsReadingListEnabled flags BUG=704487 Review-Url: https://codereview.chromium.org/2774603002 Cr-Commit-Position: refs/heads/master@{#459132} Committed: https://chromium.googlesource.com/chromium/src/+/65d69150df80f6272d3f81c855e85f0009dc7048

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adjust indentation #

Total comments: 4

Patch Set 3 : Address comments #

Patch Set 4 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -115 lines) Patch
M ios/chrome/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/app/main_controller.mm View 1 2 chunks +3 lines, -6 lines 0 comments Download
M ios/chrome/app/startup_tasks.mm View 1 2 chunks +2 lines, -5 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/about_flags.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/experimental_flags.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 2 chunks +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/reading_list/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_factory.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/sync/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory_unittest.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/tabs/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/tabs/tab_helper_util.mm View 1 2 chunks +3 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/activity_services/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/activity_service_controller.mm View 2 chunks +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 7 chunks +6 lines, -16 lines 0 comments Download
M ios/chrome/browser/ui/ntp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_controller.mm View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/reading_list/offline_page_native_content.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm View 2 chunks +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm View 1 2 chunks +3 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm View 1 2 chunks +2 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_model.mm View 2 chunks +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (11 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-23 10:14:05 UTC) #2
Olivier
https://codereview.chromium.org/2774603002/diff/1/ios/chrome/app/main_controller.mm File ios/chrome/app/main_controller.mm (right): https://codereview.chromium.org/2774603002/diff/1/ios/chrome/app/main_controller.mm#newcode702 ios/chrome/app/main_controller.mm:702: ShareExtensionService* service = reindent in all files
3 years, 9 months ago (2017-03-23 10:24:26 UTC) #3
gambard
Thanks, PTAL. https://codereview.chromium.org/2774603002/diff/1/ios/chrome/app/main_controller.mm File ios/chrome/app/main_controller.mm (right): https://codereview.chromium.org/2774603002/diff/1/ios/chrome/app/main_controller.mm#newcode702 ios/chrome/app/main_controller.mm:702: ShareExtensionService* service = On 2017/03/23 10:24:26, Olivier ...
3 years, 9 months ago (2017-03-23 10:47:47 UTC) #4
Olivier
lgtm
3 years, 9 months ago (2017-03-23 10:54:25 UTC) #5
gambard
sdefresne@: PTAL.
3 years, 9 months ago (2017-03-23 10:54:54 UTC) #7
sdefresne
lgtm https://codereview.chromium.org/2774603002/diff/20001/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm File ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm (right): https://codereview.chromium.org/2774603002/diff/20001/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm#newcode445 ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm:445: ASSERT_EQ(expected_items_count, [items count]); nit: can you inline the ...
3 years, 9 months ago (2017-03-23 15:49:06 UTC) #8
gambard
Thanks! https://codereview.chromium.org/2774603002/diff/20001/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm File ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm (right): https://codereview.chromium.org/2774603002/diff/20001/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm#newcode445 ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm:445: ASSERT_EQ(expected_items_count, [items count]); On 2017/03/23 15:49:06, sdefresne wrote: ...
3 years, 9 months ago (2017-03-23 15:53:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774603002/40001
3 years, 9 months ago (2017-03-23 15:54:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/176128) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-23 16:05:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774603002/60001
3 years, 9 months ago (2017-03-23 16:10:55 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/389784)
3 years, 9 months ago (2017-03-23 16:25:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774603002/60001
3 years, 9 months ago (2017-03-23 16:36:38 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 17:45:22 UTC) #24
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/65d69150df80f6272d3f81c855e8...

Powered by Google App Engine
This is Rietveld 408576698