ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm - Issue 2774603002: Removes the IsReadingListEnabled flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm

Issue 2774603002: Removes the IsReadingListEnabled flags (Closed)

Patch Set: fix tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/activity_services/activity_service_controller.mm ('k') | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm

diff --git a/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm b/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm

index dc0e5b7f51d2e05c8113972d6db94370b8989455..1721c8bb0a2396a5fd9828287d1e86f73adadaf9 100644

--- a/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm

+++ b/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm

@@ -7,7 +7,6 @@

#import <MobileCoreServices/MobileCoreServices.h>

#import "base/test/ios/wait_util.h"

-#include "components/reading_list/core/reading_list_switches.h"

#import "ios/chrome/browser/ui/activity_services/activity_type_util.h"

#import "ios/chrome/browser/ui/activity_services/appex_constants.h"

#import "ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h"

@@ -442,9 +441,7 @@ TEST_F(ActivityServiceControllerTest, ApplicationActivitiesForData) {

NSArray* items =

[activityController applicationActivitiesForData:data controller:nil];

- NSUInteger expected_items_count =

- reading_list::switches::IsReadingListEnabled() ? 2U : 1U;

- ASSERT_EQ(expected_items_count, [items count]);

+ ASSERT_EQ(2U, [items count]);

EXPECT_EQ([PrintActivity class], [[items objectAtIndex:0] class]);

// Verify non-printable data.

@@ -455,7 +452,7 @@ TEST_F(ActivityServiceControllerTest, ApplicationActivitiesForData) {

isPagePrintable:NO

thumbnailGenerator:DummyThumbnailGeneratorBlock()];

items = [activityController applicationActivitiesForData:data controller:nil];

- EXPECT_EQ(expected_items_count - 1, [items count]);

+ EXPECT_EQ(1U, [items count]);

}

TEST_F(ActivityServiceControllerTest, FindLoginActionTypeConformsToPublicURL) {