ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm - Issue 2774603002: Removes the IsReadingListEnabled flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm

Issue 2774603002: Removes the IsReadingListEnabled flags (Closed)

Patch Set: fix tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm ('k') | ios/chrome/browser/ui/side_swipe/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm

diff --git a/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm

index 167dcd86df957347f82f72c55df846f470854b68..068dbc9a62128714b77b800aee2c5b2217a00084 100644

--- a/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm

+++ b/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm

@@ -230,8 +230,6 @@ TEST_F(SyncSettingsCollectionViewControllerTest, TestModel) {

EXPECT_EQ(1, NumberOfItemsInSection(0));

int expected_number_of_items =

SyncSetupService::kNumberOfSyncableDatatypes + 1;

- if (!experimental_flags::IsReadingListEnabled())

- expected_number_of_items--;

EXPECT_EQ(expected_number_of_items, NumberOfItemsInSection(1));

EXPECT_EQ(2, NumberOfItemsInSection(2));

@@ -252,11 +250,6 @@ TEST_F(SyncSettingsCollectionViewControllerTest, TestModel) {

for (int i = 0; i < SyncSetupService::kNumberOfSyncableDatatypes; i++) {

SyncSetupService::SyncableDatatype dataType =

static_cast<SyncSetupService::SyncableDatatype>(i);

- if (!experimental_flags::IsReadingListEnabled() &&

- dataType == SyncSetupService::kSyncReadingList) {

- // Display Reading List only if it is enabled.

- continue;

- }

SyncSwitchItem* syncDataTypeItem = GetCollectionViewItem(1, item++);

EXPECT_NSEQ(syncDataTypeItem.text,

l10n_util::GetNSString(