Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2774503002: Track network stack error codes from UMA and UKM (Closed)

Created:
3 years, 9 months ago by Steven Holte
Modified:
3 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ios-reviews+chrome_chromium.org, halliwell+watch_chromium.org, lcwu+watch_chromium.org, pkl (ping after 24h if needed), net-reviews_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, marq+watch_chromium.org, alokp+watch_chromium.org, android-webview-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Track network stack error codes from UMA and UKM BUG=695538 Review-Url: https://codereview.chromium.org/2774503002 Cr-Commit-Position: refs/heads/master@{#461811} Committed: https://chromium.googlesource.com/chromium/src/+/035ec7fb1af183cb9a902541b273208ddb6931ab

Patch Set 1 #

Patch Set 2 : Diffbase #

Total comments: 4

Patch Set 3 : Combined histogram #

Total comments: 4

Patch Set 4 : Plural #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase on #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -66 lines) Patch
M android_webview/native/aw_metrics_log_uploader.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_metrics_log_uploader.cc View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M android_webview/native/aw_metrics_service_client_impl.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/aw_metrics_service_client_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/metrics_log_uploader.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M components/metrics/metrics_reporting_service.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/metrics_reporting_service.cc View 1 2 2 chunks +4 lines, -26 lines 0 comments Download
M components/metrics/metrics_service_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/net/net_metrics_log_uploader.h View 2 chunks +7 lines, -6 lines 0 comments Download
M components/metrics/net/net_metrics_log_uploader.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M components/metrics/net/net_metrics_log_uploader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/reporting_service.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/reporting_service.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M components/metrics/test_metrics_log_uploader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/test_metrics_log_uploader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/test_metrics_service_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/test_metrics_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ukm/ukm_reporting_service.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/ukm/ukm_reporting_service.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/today_extension/today_metrics_logger.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 4 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
Steven Holte
3 years, 9 months ago (2017-03-23 00:16:55 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/2774503002/diff/20001/components/metrics/metrics_log_uploader.h File components/metrics/metrics_log_uploader.h (right): https://codereview.chromium.org/2774503002/diff/20001/components/metrics/metrics_log_uploader.h#newcode20 components/metrics/metrics_log_uploader.h:20: typedef base::Callback<void(int, int)> UploadCallback; Nit: Document the parameters please. ...
3 years, 9 months ago (2017-03-23 15:23:43 UTC) #3
Steven Holte
https://codereview.chromium.org/2774503002/diff/20001/components/metrics/metrics_log_uploader.h File components/metrics/metrics_log_uploader.h (right): https://codereview.chromium.org/2774503002/diff/20001/components/metrics/metrics_log_uploader.h#newcode20 components/metrics/metrics_log_uploader.h:20: typedef base::Callback<void(int, int)> UploadCallback; On 2017/03/23 15:23:42, Alexei Svitkine ...
3 years, 9 months ago (2017-03-23 20:38:07 UTC) #4
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2774503002/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2774503002/diff/40001/tools/metrics/histograms/histograms.xml#newcode72923 tools/metrics/histograms/histograms.xml:72923: + HTTP response codes and network error encountered ...
3 years, 9 months ago (2017-03-23 20:41:58 UTC) #5
Steven Holte
https://codereview.chromium.org/2774503002/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2774503002/diff/40001/tools/metrics/histograms/histograms.xml#newcode72923 tools/metrics/histograms/histograms.xml:72923: + HTTP response codes and network error encountered by ...
3 years, 9 months ago (2017-03-23 21:08:53 UTC) #6
Olivier
ios LGTM
3 years, 8 months ago (2017-03-31 07:50:16 UTC) #13
boliu
android_webview rs lgtm
3 years, 8 months ago (2017-03-31 17:38:57 UTC) #14
paulmiller
On 2017/03/31 17:38:57, boliu wrote: > android_webview rs lgtm Shouldn't you also change the callback ...
3 years, 8 months ago (2017-03-31 17:46:40 UTC) #15
Steven Holte
On 2017/03/31 17:46:40, paulmiller wrote: > On 2017/03/31 17:38:57, boliu wrote: > > android_webview rs ...
3 years, 8 months ago (2017-04-04 17:53:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2774503002/100001
3 years, 8 months ago (2017-04-04 17:54:18 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 20:17:53 UTC) #23
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/035ec7fb1af183cb9a902541b273...

Powered by Google App Engine
This is Rietveld 408576698